[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 6/9] virtio-bus: introduce queue_enabled method
From: |
Cindy Lu |
Subject: |
Re: [RFC v2 6/9] virtio-bus: introduce queue_enabled method |
Date: |
Sat, 9 May 2020 14:50:34 +0800 |
On Sat, May 9, 2020 at 11:02 AM Jason Wang <address@hidden> wrote:
>
>
> On 2020/5/9 上午12:32, Cindy Lu wrote:
> > From: Jason Wang <address@hidden>
> >
> > This patch introduces queue_enabled() method which allows the
> > transport to implement its own way to report whether or not a queue is
> > enabled.
> >
> > Signed-off-by: Jason Wang <address@hidden>
>
>
> This patch should come before any of the vhost-vpda patch.
>
> Thanks
>
Sure, Will fix this
>
> > ---
> > hw/virtio/virtio.c | 6 ++++++
> > include/hw/virtio/virtio-bus.h | 4 ++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> > index 04716b5f6c..09732a8836 100644
> > --- a/hw/virtio/virtio.c
> > +++ b/hw/virtio/virtio.c
> > @@ -3169,6 +3169,12 @@ hwaddr virtio_queue_get_desc_addr(VirtIODevice
> > *vdev, int n)
> >
> > bool virtio_queue_enabled(VirtIODevice *vdev, int n)
> > {
> > + BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
> > + VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
> > +
> > + if (k->queue_enabled)
> > + return k->queue_enabled(qbus->parent, n);
> > +
> > return virtio_queue_get_desc_addr(vdev, n) != 0;
> > }
> >
> > diff --git a/include/hw/virtio/virtio-bus.h b/include/hw/virtio/virtio-bus.h
> > index 38c9399cd4..0f6f215925 100644
> > --- a/include/hw/virtio/virtio-bus.h
> > +++ b/include/hw/virtio/virtio-bus.h
> > @@ -83,6 +83,10 @@ typedef struct VirtioBusClass {
> > */
> > int (*ioeventfd_assign)(DeviceState *d, EventNotifier *notifier,
> > int n, bool assign);
> > + /*
> > + * Whether queue number n is enabled.
> > + */
> > + bool (*queue_enabled)(DeviceState *d, int n);
> > /*
> > * Does the transport have variable vring alignment?
> > * (ie can it ever call virtio_queue_set_align()?)
>
- Re: [RFC v2 4/9] vhost-vdpa: introduce vhost-vdpa net client, (continued)
- [RFC v2 6/9] virtio-bus: introduce queue_enabled method, Cindy Lu, 2020/05/08
- [RFC v2 7/9] virito-pci: implement queue_enabled method, Cindy Lu, 2020/05/08
- [RFC v2 8/9] vhost_net: set vq ready during start if necessary, Cindy Lu, 2020/05/08
- [RFC v2 9/9] vhost: introduce vhost_set_vring_ready method, Cindy Lu, 2020/05/08
- Re: [RFC v2 0/9] vDPA support in qemu, Jason Wang, 2020/05/08