[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices
From: |
Markus Armbruster |
Subject: |
[PATCH 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices |
Date: |
Mon, 18 May 2020 07:03:52 +0200 |
mac_via_realize() creates a "mos6522-q800-via1" and a
"mos6522-q800-via2" device, but neglects to realize them. Affects
machine q800.
I wonder how this ever worked. If the "device becomes real only on
realize" thing actually works, then we've always been missing these
two devices, yet nobody noticed.
Fix by realizing them right away.
Fixes: 6dca62a0000f95e0b7020aa00d0ca9b2c421f341
Cc: Laurent Vivier <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/misc/mac_via.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c
index e05623d730..ee32f72d75 100644
--- a/hw/misc/mac_via.c
+++ b/hw/misc/mac_via.c
@@ -890,6 +890,9 @@ static void mac_via_realize(DeviceState *dev, Error **errp)
object_property_add_alias(OBJECT(dev), "irq[1]", OBJECT(ms),
SYSBUS_DEVICE_GPIO_IRQ "[0]");
+ qdev_init_nofail(DEVICE(&m->mos6522_via1));
+ qdev_init_nofail(DEVICE(&m->mos6522_via2));
+
/* Pass through mos6522 input IRQs */
qdev_pass_gpios(DEVICE(&m->mos6522_via1), dev, "via1-irq");
qdev_pass_gpios(DEVICE(&m->mos6522_via2), dev, "via2-irq");
--
2.21.1
- [PATCH 14/24] macio: Put "macio-nvram" device on the macio bus, (continued)
- [PATCH 14/24] macio: Put "macio-nvram" device on the macio bus, Markus Armbruster, 2020/05/18
- [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Markus Armbruster, 2020/05/18
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Cédric Le Goater, 2020/05/18
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Andrew Jeffery, 2020/05/18
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Markus Armbruster, 2020/05/19
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Philippe Mathieu-Daudé, 2020/05/19
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Cédric Le Goater, 2020/05/19
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Joel Stanley, 2020/05/18
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, Markus Armbruster, 2020/05/19
[PATCH 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices,
Markus Armbruster <=
[PATCH 12/24] MAINTAINERS: Make section PowerNV cover pci-host/pnv* as well, Markus Armbruster, 2020/05/18
[PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/18
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Peter Maydell, 2020/05/21
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/25
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/27
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Peter Maydell, 2020/05/27
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Paolo Bonzini, 2020/05/27
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/28