[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC v3 02/11] memory: Introduce log_sync_global() to memory liste
From: |
Peter Xu |
Subject: |
[PATCH RFC v3 02/11] memory: Introduce log_sync_global() to memory listener |
Date: |
Sat, 23 May 2020 19:20:26 -0400 |
Some of the memory listener may want to do log synchronization without
being able to specify a range of memory to sync but always globally.
Such a memory listener should provide this new method instead of the
log_sync() method.
Obviously we can also achieve similar thing when we put the global
sync logic into a log_sync() handler. However that's not efficient
enough because otherwise memory_global_dirty_log_sync() may do the
global sync N times, where N is the number of flat ranges in the
address space.
Make this new method be exclusive to log_sync().
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
include/exec/memory.h | 12 ++++++++++++
memory.c | 33 +++++++++++++++++++++++----------
2 files changed, 35 insertions(+), 10 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index e000bd2f97..c0c6155ca0 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -533,6 +533,18 @@ struct MemoryListener {
*/
void (*log_sync)(MemoryListener *listener, MemoryRegionSection *section);
+ /**
+ * @log_sync_global:
+ *
+ * This is the global version of @log_sync when the listener does
+ * not have a way to synchronize the log with finer granularity.
+ * When the listener registers with @log_sync_global defined, then
+ * its @log_sync must be NULL. Vice versa.
+ *
+ * @listener: The #MemoryListener.
+ */
+ void (*log_sync_global)(MemoryListener *listener);
+
/**
* @log_clear:
*
diff --git a/memory.c b/memory.c
index 92fb8b80d7..a77c884e8e 100644
--- a/memory.c
+++ b/memory.c
@@ -2047,6 +2047,10 @@ void memory_region_set_dirty(MemoryRegion *mr, hwaddr
addr,
memory_region_get_dirty_log_mask(mr));
}
+/*
+ * If memory region `mr' is NULL, do global sync. Otherwise, sync
+ * dirty bitmap for the specified memory region.
+ */
static void memory_region_sync_dirty_bitmap(MemoryRegion *mr)
{
MemoryListener *listener;
@@ -2060,18 +2064,24 @@ static void
memory_region_sync_dirty_bitmap(MemoryRegion *mr)
* address space once.
*/
QTAILQ_FOREACH(listener, &memory_listeners, link) {
- if (!listener->log_sync) {
- continue;
- }
- as = listener->address_space;
- view = address_space_get_flatview(as);
- FOR_EACH_FLAT_RANGE(fr, view) {
- if (fr->dirty_log_mask && (!mr || fr->mr == mr)) {
- MemoryRegionSection mrs = section_from_flat_range(fr, view);
- listener->log_sync(listener, &mrs);
+ if (listener->log_sync) {
+ as = listener->address_space;
+ view = address_space_get_flatview(as);
+ FOR_EACH_FLAT_RANGE(fr, view) {
+ if (fr->dirty_log_mask && (!mr || fr->mr == mr)) {
+ MemoryRegionSection mrs = section_from_flat_range(fr,
view);
+ listener->log_sync(listener, &mrs);
+ }
}
+ flatview_unref(view);
+ } else if (listener->log_sync_global) {
+ /*
+ * No matter whether MR is specified, what we can do here
+ * is to do a global sync, because we are not capable to
+ * sync in a finer granularity.
+ */
+ listener->log_sync_global(listener);
}
- flatview_unref(view);
}
}
@@ -2758,6 +2768,9 @@ void memory_listener_register(MemoryListener *listener,
AddressSpace *as)
{
MemoryListener *other = NULL;
+ /* Only one of them can be defined for a listener */
+ assert(!(listener->log_sync && listener->log_sync_global));
+
listener->address_space = as;
if (QTAILQ_EMPTY(&memory_listeners)
|| listener->priority >= QTAILQ_LAST(&memory_listeners)->priority) {
--
2.26.2
[PATCH RFC v3 03/11] KVM: Fixup kvm_log_clear_one_slot() ioctl return check, Peter Xu, 2020/05/23
[PATCH RFC v3 02/11] memory: Introduce log_sync_global() to memory listener,
Peter Xu <=
[PATCH RFC v3 04/11] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2020/05/23
[PATCH RFC v3 05/11] KVM: Create the KVMSlot dirty bitmap on flag changes, Peter Xu, 2020/05/23
[PATCH RFC v3 06/11] KVM: Provide helper to get kvm dirty log, Peter Xu, 2020/05/23
[PATCH RFC v3 07/11] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Peter Xu, 2020/05/23
[PATCH RFC v3 08/11] KVM: Simplify dirty log sync in kvm_set_phys_mem, Peter Xu, 2020/05/23
[PATCH RFC v3 09/11] KVM: Cache kvm slot dirty bitmap size, Peter Xu, 2020/05/23
[PATCH RFC v3 10/11] KVM: Add dirty-gfn-count property, Peter Xu, 2020/05/23
[PATCH RFC v3 11/11] KVM: Dirty ring support, Peter Xu, 2020/05/23
Re: [PATCH RFC v3 00/11] KVM: Dirty ring support (QEMU part), Peter Xu, 2020/05/24
Re: [PATCH RFC v3 00/11] KVM: Dirty ring support (QEMU part), Peter Xu, 2020/05/26