[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC v3 05/11] KVM: Create the KVMSlot dirty bitmap on flag change
From: |
Peter Xu |
Subject: |
[PATCH RFC v3 05/11] KVM: Create the KVMSlot dirty bitmap on flag changes |
Date: |
Sat, 23 May 2020 19:20:29 -0400 |
Previously we have two places that will create the per KVMSlot dirty
bitmap:
1. When a newly created KVMSlot has dirty logging enabled,
2. When the first log_sync() happens for a memory slot.
The 2nd case is lazy-init, while the 1st case is not (which is a fix
of what the 2nd case missed).
To do explicit initialization of dirty bitmaps, what we're missing is
to create the dirty bitmap when the slot changed from not-dirty-track
to dirty-track. Do that in kvm_slot_update_flags().
With that, we can safely remove the 2nd lazy-init.
This change will be needed for kvm dirty ring because kvm dirty ring
does not use the log_sync() interface at all.
Also move all the pre-checks into kvm_slot_init_dirty_bitmap().
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
accel/kvm/kvm-all.c | 23 +++++++++--------------
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 6bdb7909cc..5b626af2a7 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -165,6 +165,8 @@ static QemuMutex kml_slots_lock;
#define kvm_slots_lock() qemu_mutex_lock(&kml_slots_lock)
#define kvm_slots_unlock() qemu_mutex_unlock(&kml_slots_lock)
+static void kvm_slot_init_dirty_bitmap(KVMSlot *mem);
+
int kvm_get_max_memslots(void)
{
KVMState *s = KVM_STATE(current_accel());
@@ -455,6 +457,7 @@ static int kvm_slot_update_flags(KVMMemoryListener *kml,
KVMSlot *mem,
return 0;
}
+ kvm_slot_init_dirty_bitmap(mem);
return kvm_set_user_memory_region(kml, mem, false);
}
@@ -539,8 +542,12 @@ static int
kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
#define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1))
/* Allocate the dirty bitmap for a slot */
-static void kvm_memslot_init_dirty_bitmap(KVMSlot *mem)
+static void kvm_slot_init_dirty_bitmap(KVMSlot *mem)
{
+ if (!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) || mem->dirty_bmap) {
+ return;
+ }
+
/*
* XXX bad kernel interface alert
* For dirty bitmap, kernel allocates array of size aligned to
@@ -591,11 +598,6 @@ static int
kvm_physical_sync_dirty_bitmap(KVMMemoryListener *kml,
goto out;
}
- if (!mem->dirty_bmap) {
- /* Allocate on the first log_sync, once and for all */
- kvm_memslot_init_dirty_bitmap(mem);
- }
-
d.dirty_bitmap = mem->dirty_bmap;
d.slot = mem->slot | (kml->as_id << 16);
if (kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) == -1) {
@@ -1125,14 +1127,7 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,
mem->start_addr = start_addr;
mem->ram = ram;
mem->flags = kvm_mem_flags(mr);
-
- if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
- /*
- * Reallocate the bmap; it means it doesn't disappear in
- * middle of a migrate.
- */
- kvm_memslot_init_dirty_bitmap(mem);
- }
+ kvm_slot_init_dirty_bitmap(mem);
err = kvm_set_user_memory_region(kml, mem, true);
if (err) {
fprintf(stderr, "%s: error registering slot: %s\n", __func__,
--
2.26.2
[PATCH RFC v3 03/11] KVM: Fixup kvm_log_clear_one_slot() ioctl return check, Peter Xu, 2020/05/23
[PATCH RFC v3 02/11] memory: Introduce log_sync_global() to memory listener, Peter Xu, 2020/05/23
[PATCH RFC v3 04/11] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2020/05/23
[PATCH RFC v3 05/11] KVM: Create the KVMSlot dirty bitmap on flag changes,
Peter Xu <=
[PATCH RFC v3 06/11] KVM: Provide helper to get kvm dirty log, Peter Xu, 2020/05/23
[PATCH RFC v3 07/11] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Peter Xu, 2020/05/23
[PATCH RFC v3 08/11] KVM: Simplify dirty log sync in kvm_set_phys_mem, Peter Xu, 2020/05/23
[PATCH RFC v3 09/11] KVM: Cache kvm slot dirty bitmap size, Peter Xu, 2020/05/23
[PATCH RFC v3 10/11] KVM: Add dirty-gfn-count property, Peter Xu, 2020/05/23
[PATCH RFC v3 11/11] KVM: Dirty ring support, Peter Xu, 2020/05/23
Re: [PATCH RFC v3 00/11] KVM: Dirty ring support (QEMU part), Peter Xu, 2020/05/24
Re: [PATCH RFC v3 00/11] KVM: Dirty ring support (QEMU part), Peter Xu, 2020/05/26