[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu"
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices |
Date: |
Wed, 27 May 2020 18:08:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On Wed, 27 May 2020 at 15:12, Markus Armbruster <address@hidden> wrote:
>> * PATCH 08: in a realize method. Can't actually fail, so let's use
>> &error_abort.
>>
>> * PATCH 09 (this one): likewise.
>
> I disagree with these. We're in a realize function, the API
> says "on errors, report them via the Error* you got passed",
> so we should do that, not blow up. &error_abort only makes
> sense if (a) we have no better way to report errors than
> to abort (which isn't the case here) or (b) if we can guarantee
> that in fact the thing we're doing won't ever fail
I detest impossible (and therefore untestable) error paths.
> (which we can't here without knowing more about the internal
> implementation details of the MOS6522 device than we
> really ought to).
At least the child devices are all defined in the same file.
My second line of defense: my patches are strict improvments. If you
want further improvements, I'd prefer you propose them as patches on top
of mine.
- Re: [PATCH 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices, (continued)
- [PATCH 12/24] MAINTAINERS: Make section PowerNV cover pci-host/pnv* as well, Markus Armbruster, 2020/05/18
- [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/18
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Peter Maydell, 2020/05/21
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/25
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/27
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Peter Maydell, 2020/05/27
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Paolo Bonzini, 2020/05/27
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/28
- Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices,
Markus Armbruster <=
[PATCH 07/24] auxbus: Fix aux-to-i2c-bridge to be a subtype of aux-slave, Markus Armbruster, 2020/05/18
[PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge", Markus Armbruster, 2020/05/18
Re: [PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge", Edgar E. Iglesias, 2020/05/18
Re: [PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge", Peter Maydell, 2020/05/18