Re: [PATCH 5/7] softfloat: return low bits of quotient from floatx80_modrem

[Richard Henderson]

On 6/5/20 12:01 PM, Joseph Myers wrote:
> Both x87 and m68k need the low parts of the quotient for their
> remainder operations.  Arrange for floatx80_modrem to track those bits
> and return them via a pointer.
> 
> The architectures using float32_rem and float64_rem do not appear to
> need this information, so the *_rem interface is left unchanged and
> the information returned only from floatx80_modrem.  The logic used to
> determine the low 7 bits of the quotient for m68k
> (target/m68k/fpu_helper.c:make_quotient) appears completely bogus (it
> looks at the result of converting the remainder to integer, the
> quotient having been discarded by that point); this patch does not
> change that, but the m68k maintainers may wish to do so.
> 
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>
> ---
>  fpu/softfloat.c         | 23 ++++++++++++++++++-----
>  include/fpu/softfloat.h |  3 ++-
>  2 files changed, 20 insertions(+), 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~