[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operation
From: |
Richard Henderson |
Subject: |
Re: [PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operations |
Date: |
Sat, 6 Jun 2020 12:16:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/5/20 12:02 PM, Joseph Myers wrote:
> The x87 fprem1 emulation is currently based around conversion to
> double, which is inherently unsuitable for a good emulation of any
> floatx80 operation. Reimplement using the soft-float floatx80
> remainder operations.
>
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>
> ---
> target/i386/fpu_helper.c | 96 +++++++++++++++++++---------------------
> 1 file changed, 45 insertions(+), 51 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
I would merge patch 7 into this one; I don't see value in keeping them separate.
r~
- Re: [PATCH 1/7] softfloat: merge floatx80_mod and floatx80_rem, (continued)
- [PATCH 2/7] softfloat: fix floatx80 remainder pseudo-denormal check for zero, Joseph Myers, 2020/06/05
- [PATCH 3/7] softfloat: do not return pseudo-denormal from floatx80 remainder, Joseph Myers, 2020/06/05
- [PATCH 4/7] softfloat: do not set denominator high bit for floatx80 remainder, Joseph Myers, 2020/06/05
- [PATCH 5/7] softfloat: return low bits of quotient from floatx80_modrem, Joseph Myers, 2020/06/05
- [PATCH 6/7] target/i386: reimplement fprem1 using floatx80 operations, Joseph Myers, 2020/06/05
- [PATCH 7/7] target/i386: reimplement fprem using floatx80 operations, Joseph Myers, 2020/06/05