[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/16] python: add mypy support to python/qemu
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 00/16] python: add mypy support to python/qemu |
Date: |
Mon, 8 Jun 2020 19:41:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/8/20 5:33 PM, Kevin Wolf wrote:
> Am 08.06.2020 um 17:19 hat John Snow geschrieben:
>>
>>
>> On 6/5/20 5:26 AM, Kevin Wolf wrote:
>>> Am 04.06.2020 um 22:22 hat John Snow geschrieben:
>>>> Based-on: 20200604195252.20739-1-jsnow@redhat.com
>>>>
>>>> This series is extracted from my larger series that attempted to bundle
>>>> our python module as an installable module. These fixes don't require that,
>>>> so they are being sent first as I think there's less up for debate in here.
>>>>
>>>> This requires my "refactor shutdown" patch as a pre-requisite.
>>>
>>> You didn't like my previous R-b? Here's a new one. :-)
>>>
>>> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>>>
>>
>> I felt like I should address the feedback, and though I could have
>> applied the R-B to patches I didn't change, it was ... faster to just
>> re-send it.
>>
>> Serious question: How do you apply people's R-Bs to your patches? At the
>> moment, it's pretty manually intensive for me. I use stgit and I pop all
>> of the patches off (stg pop -n 100), and then one-at-a-time I `stg push;
>> stg edit` and copy-paste the R-B into it.
wget https://patchew.org/QEMU/${MSG_ID}/mbox
git am mbox
Where ${MSG_ID} is the Message-Id of the series cover letter.
>>
>> It's easier when I'm just pulling other people's patches from the ML,
>> the patches tool handles it for me. It's updating my own patches that's
>> a drag and prone to error.
>
> It's a manual process for me, too. Just that I don't use stgit, but
> 'git rebase -i'.
>
> Kevin
>
- [PATCH v3 10/16] python/machine.py: Handle None events in events_wait, (continued)
- [PATCH v3 10/16] python/machine.py: Handle None events in events_wait, John Snow, 2020/06/04
- [PATCH v3 11/16] python/machine.py: use qmp.command, John Snow, 2020/06/04
- [PATCH v3 15/16] iotests.py: Adjust HMP kwargs typing, John Snow, 2020/06/04
- [PATCH v3 13/16] python/machine.py: fix _popen access, John Snow, 2020/06/04
- [PATCH v3 14/16] python/qemu: make 'args' style arguments immutable, John Snow, 2020/06/04
- [PATCH v3 16/16] python/qemu: Add mypy type annotations, John Snow, 2020/06/04
- [PATCH v3 01/16] python/qmp.py: Define common types, John Snow, 2020/06/04
- Re: [PATCH v3 00/16] python: add mypy support to python/qemu, Kevin Wolf, 2020/06/05
- Re: [PATCH v3 00/16] python: add mypy support to python/qemu, John Snow, 2020/06/08
- Re: [PATCH v3 00/16] python: add mypy support to python/qemu, Kevin Wolf, 2020/06/08
- Re: [PATCH v3 00/16] python: add mypy support to python/qemu,
Philippe Mathieu-Daudé <=
- Re: [PATCH v3 00/16] python: add mypy support to python/qemu, Markus Armbruster, 2020/06/09
- applying mailing list review tags (was: Re: [PATCH v3 00/16] python: add mypy support to python/qemu), John Snow, 2020/06/16
- Re: applying mailing list review tags (was: Re: [PATCH v3 00/16] python: add mypy support to python/qemu), Philippe Mathieu-Daudé, 2020/06/16
- Re: [PATCH v3 00/16] python: add mypy support to python/qemu, John Snow, 2020/06/17
- Re: applying mailing list review tags (was: Re: [PATCH v3 00/16] python: add mypy support to python/qemu), Paolo Bonzini, 2020/06/17
Re: [PATCH v3 00/16] python: add mypy support to python/qemu, Philippe Mathieu-Daudé, 2020/06/17