Re: [PATCH v3 00/16] python: add mypy support to python/qemu

[John Snow]

On 6/17/20 1:18 PM, Philippe Mathieu-Daudé wrote:
> On 6/4/20 10:22 PM, John Snow wrote:
>> Based-on: 20200604195252.20739-1-jsnow@redhat.com
>>
>> This series is extracted from my larger series that attempted to bundle
>> our python module as an installable module. These fixes don't require that,
>> so they are being sent first as I think there's less up for debate in here.
>>
> [...]
>>
>> John Snow (16):
>>   python/qmp.py: Define common types
>>   iotests.py: use qemu.qmp type aliases
>>   python/qmp.py: re-absorb MonitorResponseError
>>   python/qmp.py: Do not return None from cmd_obj
>>   python/qmp.py: add casts to JSON deserialization
>>   python/qmp.py: add QMPProtocolError
>>   python/machine.py: Fix monitor address typing
>>   python/machine.py: reorder __init__
>>   python/machine.py: Don't modify state in _base_args()
>>   python/machine.py: Handle None events in events_wait
>>   python/machine.py: use qmp.command
>>   python/machine.py: Add _qmp access shim
>>   python/machine.py: fix _popen access
>>   python/qemu: make 'args' style arguments immutable
>>   iotests.py: Adjust HMP kwargs typing
>>   python/qemu: Add mypy type annotations
>>
>>  python/qemu/accel.py          |   8 +-
>>  python/qemu/machine.py        | 286 ++++++++++++++++++++--------------
>>  python/qemu/qmp.py            | 111 +++++++++----
>>  python/qemu/qtest.py          |  53 ++++---
>>  scripts/render_block_graph.py |   7 +-
>>  tests/qemu-iotests/iotests.py |  11 +-
>>  6 files changed, 298 insertions(+), 178 deletions(-)
>>
> 
> Thanks, applied to my python-next tree:
> https://gitlab.com/philmd/qemu/commits/python-next
> 

Awesome, thanks!