[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code
From: |
Paolo Bonzini |
Subject: |
Re: [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used |
Date: |
Tue, 9 Jun 2020 13:03:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/06/20 18:00, Philippe Mathieu-Daudé wrote:
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/slavio_timer.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/timer/slavio_timer.c b/hw/timer/slavio_timer.c
> index 4c5d65e391..16f21669bf 100644
> --- a/hw/timer/slavio_timer.c
> +++ b/hw/timer/slavio_timer.c
> @@ -31,6 +31,7 @@
> #include "migration/vmstate.h"
> #include "trace.h"
> #include "qemu/module.h"
> +#include "hw/qdev-deprecated.h"
>
> /*
> * Registers of hardware timer in sun4m.
> @@ -392,6 +393,8 @@ static void slavio_timer_init(Object *obj)
> unsigned int i;
> TimerContext *tc;
>
> + qdev_warn_deprecated_function_used();
> +
> for (i = 0; i <= MAX_CPUS; i++) {
> uint64_t size;
> char timer_name[20];
>
This one is okay.
Paolo
- Re: [RFC PATCH 27/35] hw/ppc/ppc: Emit warning when old code is used, (continued)
- [RFC PATCH 29/35] hw/ppc/ppc_booke: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 28/35] hw/ppc/ppc4xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 30/35] hw/ppc/virtex_ml507: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 31/35] hw/sh4: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 32/35] hw/riscv: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 33/35] hw/timer/slavio_timer: Emit warning when old code is used,
Paolo Bonzini <=
- [RFC PATCH 34/35] hw/usb/hcd-musb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- [RFC PATCH 35/35] hw/xtensa/xtfpga: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/06/08
- Re: [RFC PATCH 00/35] hw/qdev: Warn when using pre-qdev/QOM devices, Peter Maydell, 2020/06/08