Re: [PATCH v9 00/10] acpi: i386 tweaks

[no-reply]

Patchew URL: 20200617071138.11159-1-kraxel@redhat.com/">https://patchew.org/QEMU/20200617071138.11159-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v9 00/10] acpi: i386 tweaks
Type: series
Message-id: 20200617071138.11159-1-kraxel@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      
patchew/20200617043757.1623337-1-richard.henderson@linaro.org -> 
patchew/20200617043757.1623337-1-richard.henderson@linaro.org
 * [new tag]         patchew/20200617071138.11159-1-kraxel@redhat.com -> 
patchew/20200617071138.11159-1-kraxel@redhat.com
Switched to a new branch 'test'
95563cf acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.
f9a1499 acpi: drop build_piix4_pm()
2f9982f acpi: drop serial/parallel enable bits from dsdt
76f8de5 acpi: simplify build_isa_devices_aml()
9f96ea9 acpi: factor out fw_cfg_add_acpi_dsdt()
5dfc8bd acpi: move aml builder code for i8042 (kbd+mouse) device
23a13c5 floppy: move cmos_get_fd_drive_type() from pc
3b35189 floppy: make isa_fdc_get_drive_max_chs static
cd046a4 acpi: move aml builder code for floppy device
fc9cc42 acpi: bios-tables-test: show more context on asl diffs

=== OUTPUT BEGIN ===
1/10 Checking commit fc9cc42f4d41 (acpi: bios-tables-test: show more context on 
asl diffs)
2/10 Checking commit cd046a45c7eb (acpi: move aml builder code for floppy 
device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#245: 
new file mode 100644

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.ipmikcs and 
stubs/cmos.c found

total: 1 errors, 1 warnings, 219 lines checked

Patch 2/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/10 Checking commit 3b3518992288 (floppy: make isa_fdc_get_drive_max_chs 
static)
4/10 Checking commit 23a13c5df0d0 (floppy: move cmos_get_fd_drive_type() from 
pc)
5/10 Checking commit 5dfc8bd9ac77 (acpi: move aml builder code for i8042 
(kbd+mouse) device)
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.ipmikcs and 
hw/input/pckbd.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.ipmibt and 
hw/input/pckbd.c found

total: 2 errors, 0 warnings, 100 lines checked

Patch 5/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/10 Checking commit 9f96ea9f1582 (acpi: factor out fw_cfg_add_acpi_dsdt())
7/10 Checking commit 76f8de5f47c1 (acpi: simplify build_isa_devices_aml())
8/10 Checking commit 2f9982f86b2a (acpi: drop serial/parallel enable bits from 
dsdt)
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.acpihmat and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.bridge and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.cphp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.dimmpxm and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.ipmikcs and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.memhp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.numamem and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.acpihmat and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.bridge and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.cphp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.dimmpxm and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.ipmibt and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.memhp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.mmio64 and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.numamem and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.tis and 
hw/i386/acpi-build.c found

total: 18 errors, 0 warnings, 41 lines checked

Patch 8/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/10 Checking commit f9a14999e629 (acpi: drop build_piix4_pm())
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.acpihmat and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.bridge and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.cphp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.dimmpxm and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.ipmikcs and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.memhp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/pc/DSDT.numamem and 
hw/i386/acpi-build.c found

total: 8 errors, 0 warnings, 28 lines checked

Patch 9/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/10 Checking commit 95563cf96f9c (acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.)
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.acpihmat and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.bridge and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.cphp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.dimmpxm and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.ipmibt and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.memhp and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.mmio64 and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.numamem and 
hw/i386/acpi-build.c found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/DSDT.tis and 
hw/i386/acpi-build.c found

total: 10 errors, 0 warnings, 23 lines checked

Patch 10/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200617071138.11159-1-kraxel@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200617071138.11159-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com