[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 07/10] acpi: simplify build_isa_devices_aml()
From: |
Gerd Hoffmann |
Subject: |
[PATCH v9 07/10] acpi: simplify build_isa_devices_aml() |
Date: |
Wed, 17 Jun 2020 09:11:35 +0200 |
x86 machines can have a single ISA bus only.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/i386/acpi-build.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 19e9c298dc8f..d27cecc877c4 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -979,18 +979,14 @@ static void build_isa_devices_aml(Aml *table)
{
VMBusBridge *vmbus_bridge = vmbus_bridge_find();
bool ambiguous;
-
- Aml *scope = aml_scope("_SB.PCI0.ISA");
Object *obj = object_resolve_path_type("", TYPE_ISA_BUS, &ambiguous);
+ Aml *scope;
- if (ambiguous) {
- error_report("Multiple ISA busses, unable to define IPMI ACPI data");
- } else if (!obj) {
- error_report("No ISA bus, unable to define IPMI ACPI data");
- } else {
- build_acpi_ipmi_devices(scope, BUS(obj), "\\_SB.PCI0.ISA");
- isa_build_aml(ISA_BUS(obj), scope);
- }
+ assert(obj && !ambiguous);
+
+ scope = aml_scope("_SB.PCI0.ISA");
+ build_acpi_ipmi_devices(scope, BUS(obj), "\\_SB.PCI0.ISA");
+ isa_build_aml(ISA_BUS(obj), scope);
if (vmbus_bridge) {
aml_append(scope, build_vmbus_device_aml(vmbus_bridge));
--
2.18.4
- Re: [PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs, (continued)
- [PATCH v9 04/10] floppy: move cmos_get_fd_drive_type() from pc, Gerd Hoffmann, 2020/06/17
- [PATCH v9 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion., Gerd Hoffmann, 2020/06/17
- [PATCH v9 06/10] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/06/17
- [PATCH v9 07/10] acpi: simplify build_isa_devices_aml(),
Gerd Hoffmann <=
- [PATCH v9 09/10] acpi: drop build_piix4_pm(), Gerd Hoffmann, 2020/06/17
- [PATCH v9 08/10] acpi: drop serial/parallel enable bits from dsdt, Gerd Hoffmann, 2020/06/17
- [PATCH v9 05/10] acpi: move aml builder code for i8042 (kbd+mouse) device, Gerd Hoffmann, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks, no-reply, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks, no-reply, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks, no-reply, 2020/06/17
- Re: [PATCH v9 00/10] acpi: i386 tweaks, Michael S. Tsirkin, 2020/06/18