Re: [PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs

[Philippe Mathieu-Daudé]

On 6/17/20 9:11 AM, Gerd Hoffmann wrote:
> Makes it easier to create good commit messages from the logs.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  tests/qtest/bios-tables-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index b482f76c03d4..c315156858f4 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -469,7 +469,7 @@ static void test_acpi_asl(test_data *data)
>                  fflush(stderr);
>                  if (getenv("V")) {
>                      const char *diff_env = getenv("DIFF");
> -                    const char *diff_cmd = diff_env ? diff_env : "diff -u";
> +                    const char *diff_cmd = diff_env ? diff_env : "diff -U 
> 16";
>                      char *diff = g_strdup_printf("%s %s %s", diff_cmd,
>                                                   exp_sdt->asl_file, 
> sdt->asl_file);
>                      int out = dup(STDOUT_FILENO);
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>