Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts

[Stefan Berger]

On 6/23/20 9:09 AM, Michael S. Tsirkin wrote:
> On Wed, Jun 17, 2020 at 10:22:57AM -0400, Stefan Berger wrote:
> > This series of patches enables the usage of the TPM TIS with interrupts.
> > We use the unused IRQ 13, which is the only one accepted by Windows.
> >
> >      Stefan
>
> ACPI parts:
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> How do we want this merged? TPM tree or mine?

Queued it here: https://github.com/stefanberger/qemu-tpm/commits/tpm-next

Was going to send a PR later this week with this part. Will add your Rb-s.


   Stefan


> > v3->v4:
> >   - Changed TPM_IRQ_DISABLED from -1 to ~0
> >
> > v2->v3:
> >   - Extended series to disable IRQ for TIS on sysbus
> >
> > v1->v2:
> >   - Added updated DSDT
> >
> > Stefan Berger (8):
> >    tpm_tis: Allow lowering of IRQ also when locality is not active
> >    tpm: Extend TPMIfClass with get_irqnum() function
> >    tests: Temporarily ignore DSDT table differences
> >    tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ
> >    acpi: Enable TPM IRQ
> >    tests: Add updated DSDT
> >    tpm: Guard irq related ops in case interrupts are disabled
> >    tpm: Disable interrupt support for TIS on sysbus
> >
> >   hw/i386/acpi-build.c         |  11 +++++------
> >   hw/tpm/tpm_tis_common.c      |  12 +++++++++---
> >   hw/tpm/tpm_tis_isa.c         |  17 ++++++++++++++---
> >   hw/tpm/tpm_tis_sysbus.c      |  12 +++++++++++-
> >   include/hw/acpi/tpm.h        |   3 ++-
> >   include/sysemu/tpm.h         |  12 ++++++++++++
> >   tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes
> >   7 files changed, 53 insertions(+), 14 deletions(-)
> >
> > --
> > 2.24.1