Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts

[Stefan Berger]

On 6/18/20 3:27 AM, Auger Eric wrote:

I have to defer this series since there are some things that don't work 
on the Linux level with IRQ 13 (edge) while they do work fine on the old 
IRQ 5 (festeoi). I know which changes to make to Linux so that it works 
on IRQ 13 as well, but I am not sure whether those changes are 
acceptable. So now we could upstream this one here:

[PATCH v4 4/8] tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and 
TPM_TIS_SYSBUS_IRQ


   Stefan

> Hi Stefan,
>
> On 6/17/20 4:22 PM, Stefan Berger wrote:
> > This series of patches enables the usage of the TPM TIS with interrupts.
> > We use the unused IRQ 13, which is the only one accepted by Windows.
> >
> >      Stefan
> >
> > v3->v4:
> >   - Changed TPM_IRQ_DISABLED from -1 to ~0
> >
> > v2->v3:
> >   - Extended series to disable IRQ for TIS on sysbus
> >
> > v1->v2:
> >   - Added updated DSDT
> >
> > Stefan Berger (8):
> >    tpm_tis: Allow lowering of IRQ also when locality is not active
> >    tpm: Extend TPMIfClass with get_irqnum() function
> >    tests: Temporarily ignore DSDT table differences
> >    tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ
> >    acpi: Enable TPM IRQ
> >    tests: Add updated DSDT
> >    tpm: Guard irq related ops in case interrupts are disabled
> >    tpm: Disable interrupt support for TIS on sysbus
> >
> >   hw/i386/acpi-build.c         |  11 +++++------
> >   hw/tpm/tpm_tis_common.c      |  12 +++++++++---
> >   hw/tpm/tpm_tis_isa.c         |  17 ++++++++++++++---
> >   hw/tpm/tpm_tis_sysbus.c      |  12 +++++++++++-
> >   include/hw/acpi/tpm.h        |   3 ++-
> >   include/sysemu/tpm.h         |  12 ++++++++++++
> >   tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes
> >   7 files changed, 53 insertions(+), 14 deletions(-)
> I checked this series does not bring any regression on ARM TPM-TIS
> device. So if useful/relevant, feel free to add my T-b from the ARM pov.
>
> Tested-by: Eric Auger <eric.auger@redhat.com>
>
> Thanks
>
> Eric