Re: [PATCH 34/46] qom: Don't handle impossible object_property_get

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link(

From:	Eric Blake
Subject:	Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure
Date:	Wed, 24 Jun 2020 16:13:33 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 6/24/20 11:43 AM, Markus Armbruster wrote:

Don't handle object_property_get_link() failure that can't happen
unless the programmer screwed up, pass &error_abort.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---


Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), (continued)
- [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Markus Armbruster, 2020/06/24
  - Re: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Eric Blake, 2020/06/24
  - Re: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Vladimir Sementsov-Ogievskiy, 2020/06/25
  - RE: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Gonglei (Arei), 2020/06/27
- [PATCH 20/46] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/06/24
  - Re: [PATCH 20/46] block: Avoid error accumulation in bdrv_img_create(), Eric Blake, 2020/06/24
    - Re: [PATCH 20/46] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/06/25
- [PATCH 38/46] qom: Smooth error checking with Coccinelle, Markus Armbruster, 2020/06/24
  - Re: [PATCH 38/46] qom: Smooth error checking with Coccinelle, Eric Blake, 2020/06/24
- [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/06/24
  - Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure, Eric Blake <=
  - Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure, Philippe Mathieu-Daudé, 2020/06/25
    - Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/06/25
    - Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure, Philippe Mathieu-Daudé, 2020/06/29
- [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar, Markus Armbruster, 2020/06/24
  - Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar, Eric Blake, 2020/06/24
  - Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar, Vladimir Sementsov-Ogievskiy, 2020/06/29
  - Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar, Vladimir Sementsov-Ogievskiy, 2020/06/29
    - Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar, Vladimir Sementsov-Ogievskiy, 2020/06/29
- [PATCH 16/46] qemu-option: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/06/24
  - Re: [PATCH 16/46] qemu-option: Make functions taking Error ** return bool, not void, Eric Blake, 2020/06/24

Prev by Date: QEMU | Pipeline #159786827 has failed for master | d4b78317
Next by Date: Re: [PATCH 35/46] qom: Use return values to check for error where that's simpler
Previous by thread: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure
Next by thread: Re: [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure
Index(es):
- Date
- Thread