[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/46] block: Avoid error accumulation in bdrv_img_create()
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 20/46] block: Avoid error accumulation in bdrv_img_create() |
Date: |
Thu, 25 Jun 2020 15:47:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On 6/24/20 11:43 AM, Markus Armbruster wrote:
>> When creating an image fails because the format doesn't support option
>> "backing_file" or "backing_fmt", bdrv_img_create() first has
>> qemu_opt_set() put a generic error into @local_err, then puts the real
>> error into @errp with error_setg(), and then propagates the former to
>> the latter, which throws away the generic error. A bit complicated,
>> but works.
>
> Hmm - may interact with my series to deprecate -b without -F. We'll
> deal with the fallout based on whatever lands first.
>
>>
>> Not that qemu_opt_set() returns a useful value, we can simply ignore
>
> s/Not/Now/
Will fix.
>> the generic error instead.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> block.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Aha - you fixed 2 of the 4 cases that I noticed in 17/46.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks!
- Re: [PATCH 40/46] qom: Make functions taking Error ** return bool, not 0/-1, (continued)
- [PATCH 43/46] qdev: Smooth error checking manually, Markus Armbruster, 2020/06/24
- [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Markus Armbruster, 2020/06/24
- [PATCH 20/46] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/06/24
- [PATCH 38/46] qom: Smooth error checking with Coccinelle, Markus Armbruster, 2020/06/24
- [PATCH 34/46] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/06/24
- [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar, Markus Armbruster, 2020/06/24