[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.1] net/colo: Remove unused trace event
From: |
Roman Bolshakov |
Subject: |
Re: [PATCH-for-5.1] net/colo: Remove unused trace event |
Date: |
Wed, 15 Jul 2020 22:27:21 +0300 |
On Wed, Jul 15, 2020 at 04:13:02PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 15, 2020 at 04:31:30PM +0200, Philippe Mathieu-Daudé wrote:
> > Unused trace event cause build failure when using the dtrace backend:
> >
> > "probe colo_compare_miscompare doesn't exist"
> >
> > Fixes: f4b618360e ("colo-compare: add TCP, UDP, ICMP packet comparison")
> > Reported-by: Roman Bolshakov <r.bolshakov@yadro.com>
>
> Note Roman indicated on IRC that this is seen with dtrace on macOS and
> there were other problems too.
>
> Unless someone knows that QEMU's dtrace support worked on macOS in the
> past, I think we don't need and simply consider dtrace unsupported on
> macOS right now until someone can get it into more robust shape on
> macOS.
>
Hi Daniel,
I've got it working and I can see qemu trace points from
sudo dtrace -m qemu-system-x86_64 -l
I'm wrapping a series that resolves all the issues along the way.
Thanks,
Roman