[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1] sd/milkymist-memcard: Fix format string
From: |
Markus Armbruster |
Subject: |
Re: [PATCH for-5.1] sd/milkymist-memcard: Fix format string |
Date: |
Thu, 23 Jul 2020 11:38:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Stefan Weil <sw@weilnetz.de> writes:
Let's add
Fixes: b98e8d1230ff7023bb34ddeb7194424dfcbaf789
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/sd/milkymist-memcard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
> index afdb8aa0c0..11f61294fc 100644
> --- a/hw/sd/milkymist-memcard.c
> +++ b/hw/sd/milkymist-memcard.c
> @@ -281,7 +281,7 @@ static void milkymist_memcard_realize(DeviceState *dev,
> Error **errp)
> carddev = qdev_new(TYPE_SD_CARD);
> qdev_prop_set_drive(carddev, "drive", blk);
> if (!qdev_realize_and_unref(carddev, BUS(&s->sdbus), &err)) {
> - error_propagate_prepend(errp, err, "failed to init SD card: %s");
> + error_propagate_prepend(errp, err, "failed to init SD card");
> return;
> }
> s->enabled = blk && blk_is_inserted(blk);
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Missed because error_propagate_prepend() lacks GCC_FMT_ATTR(). I'll fix
that. Since the fix needs to be on top of this patch, me taking both
patches through my tree would be easier for me, assuming Michael doesn't
mind.
Thanks for the fix, Stefan!