[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in s
From: |
Richard Henderson |
Subject: |
Re: [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in static initializers |
Date: |
Fri, 24 Jul 2020 11:23:23 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 7/23/20 11:45 PM, Alex Bennée wrote:
> From: Laszlo Ersek <lersek@redhat.com>
>
> Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an
> object that has static storage duration shall be constant expressions or
> string literals".
>
> The compound literal produced by the make_floatx80() macro is not such a
> constant expression, per 6.6p7-9. (An implementation may accept it,
> according to 6.6p10, but is not required to.)
>
> Therefore using "floatx80_zero" and make_floatx80() for initializing
> "f2xm1_table" and "fpatan_table" is not portable. And gcc-4.8 in RHEL-7.6
> actually chokes on them:
>
>> target/i386/fpu_helper.c:871:5: error: initializer element is not constant
>> { make_floatx80(0xbfff, 0x8000000000000000ULL),
>> ^
> We've had the make_floatx80_init() macro for this purpose since commit
> 3bf7e40ab914 ("softfloat: fix for C99", 2012-03-17), so let's use that
> macro again.
>
> Fixes: eca30647fc07
> Fixes: ff57bb7b6326
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Joseph Myers <joseph@codesourcery.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Richard Henderson <rth@twiddle.net>
> Link: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg06566.html
> Link: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg04714.html
> Message-Id: <20200716144251.23004-1-lersek@redhat.com>
> Message-Id: <20200722062902.24509-8-alex.bennee@linaro.org>
> ---
> include/fpu/softfloat.h | 1 +
> target/i386/fpu_helper.c | 426 +++++++++++++++++++--------------------
> 2 files changed, 214 insertions(+), 213 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v3 02/16] semihosting: defer connect_chardevs a little more to use serialx, (continued)
- [PATCH v3 02/16] semihosting: defer connect_chardevs a little more to use serialx, Alex Bennée, 2020/07/24
- [PATCH v3 04/16] util: add qemu_get_host_physmem utility function, Alex Bennée, 2020/07/24
- [PATCH v3 06/16] accel/tcg: better handle memory constrained systems, Alex Bennée, 2020/07/24
- [PATCH v3 05/16] util/oslib-win32: add qemu_get_host_physmem implementation, Alex Bennée, 2020/07/24
- [PATCH v3 08/16] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback, Alex Bennée, 2020/07/24
- [PATCH v3 10/16] tests/docker: fix binfmt_misc image building, Alex Bennée, 2020/07/24
- [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in static initializers, Alex Bennée, 2020/07/24
- Re: [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in static initializers,
Richard Henderson <=
- [PATCH v3 12/16] linux-user: fix clock_nanosleep(), Alex Bennée, 2020/07/24
- [PATCH v3 16/16] tests/vm: add shutdown timeout in basevm.py, Alex Bennée, 2020/07/24
- [PATCH v3 11/16] tests/docker: add support for DEB_KEYRING, Alex Bennée, 2020/07/24
- [PATCH v3 14/16] python/qemu: Cleanup changes to ConsoleSocket, Alex Bennée, 2020/07/24
- [PATCH v3 09/16] tests/docker: fix update command due to python3 str/bytes distinction, Alex Bennée, 2020/07/24
- [PATCH v3 13/16] linux-user, ppc: fix clock_nanosleep() for linux-user-ppc, Alex Bennée, 2020/07/24
- [PATCH v3 15/16] python/qemu: Change ConsoleSocket to optionally drain socket., Alex Bennée, 2020/07/24