[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly. |
Date: |
Tue, 25 Aug 2020 09:59:49 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyonggang@gmail.com wrote:
> From: Yonggang Luo <luoyonggang@gmail.com>
>
> ---
> scripts/undefsym.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/undefsym.sh b/scripts/undefsym.sh
> index b9ec332e95..8189308b2c 100755
> --- a/scripts/undefsym.sh
> +++ b/scripts/undefsym.sh
> @@ -1,4 +1,4 @@
> -#! /usr/bin/env bash
> +#!/bin/sh
Does this script actually work on non-bash shells ? If not, then this
change will likely break on plaforms where /bin/sh is not bash.
>
> # Before a shared module's DSO is produced, a static library is built for it
> # and passed to this script. The script generates -Wl,-u options to force
> --
> 2.27.0.windows.1
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[PATCH 5/5] configure: replace all $PWD with $build_path that can handling msys2 properly, luoyonggang, 2020/08/25
Re: [PATCH 1/5] meson: SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched. if the path are start with C:/ and E:/, Daniel P . Berrangé, 2020/08/25