[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/20] tests/qapi/doc-good.json: Prepare for qapi-doc Sphi
From: |
Peter Maydell |
Subject: |
Re: [PATCH v5 06/20] tests/qapi/doc-good.json: Prepare for qapi-doc Sphinx extension |
Date: |
Fri, 4 Sep 2020 13:17:45 +0100 |
On Fri, 4 Sep 2020 at 09:10, Markus Armbruster <armbru@redhat.com> wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
> > doc-good.json tests doc comment parser corner cases. We're about to
> > largely replace it by a Sphinx extension, which will have different
> > corner cases. Tweak the test so it passes both with the old parser
> > and the Sphinx extension, by making it match the more restrictive
> > rST syntax:
> >
> > * in a single list the bullet types must all match
> > * lists must have leading and following blank lines
> > * indentation is important
>
> Actually, indentation has always been important, but the conversion to
> rST changes where and how it matters. Perhaps:
>
> * the rules on when and where indentation matters differ
The commit message text here is the text you recommended in your
review of v4 of this series...
https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00988.html
thanks
-- PMM