[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/20] python/qemu: Add mypy type annotations
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH 11/20] python/qemu: Add mypy type annotations |
|
Date: |
Wed, 7 Oct 2020 12:46:16 +0200 |
Am 07.10.2020 um 01:58 hat John Snow geschrieben:
> These should all be purely annotations with no changes in behavior at
> all. You need to be in the python folder, but you should be able to
> confirm that these annotations are correct (or at least self-consistent)
> by running `mypy --strict qemu`.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
'mypy --strict qemu' doesn't have clean output after this patch because
ConsoleSocket isn't converted yet. But then, technically the commit
message doesn't make this claim, and you can indeed check the
self-consistency when you ignore the ConsoleSocket related errors, so
probably not a problem.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
- Re: [PATCH 07/20] python/machine.py: Add _qmp access shim, (continued)
[PATCH 09/20] python/qemu: make 'args' style arguments immutable, John Snow, 2020/10/06
[PATCH 10/20] iotests.py: Adjust HMP kwargs typing, John Snow, 2020/10/06
[PATCH 11/20] python/qemu: Add mypy type annotations, John Snow, 2020/10/06
- Re: [PATCH 11/20] python/qemu: Add mypy type annotations,
Kevin Wolf <=
[PATCH 12/20] python/qemu/console_socket.py: Correct type of recv(), John Snow, 2020/10/06
[PATCH 13/20] python/qemu/console_socket.py: fix typing of settimeout, John Snow, 2020/10/06
[PATCH 14/20] python/qemu/console_socket.py: Clarify type of drain_thread, John Snow, 2020/10/06
[PATCH 15/20] python/qemu/console_socket.py: Add type hint annotations, John Snow, 2020/10/06