[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/20] python/qemu: Add mypy type annotations

From: John Snow
Subject: Re: [PATCH 11/20] python/qemu: Add mypy type annotations
Date: Wed, 7 Oct 2020 14:48:18 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 10/7/20 6:46 AM, Kevin Wolf wrote:
Am 07.10.2020 um 01:58 hat John Snow geschrieben:
These should all be purely annotations with no changes in behavior at
all. You need to be in the python folder, but you should be able to
confirm that these annotations are correct (or at least self-consistent)
by running `mypy --strict qemu`.

Signed-off-by: John Snow <jsnow@redhat.com>

'mypy --strict qemu' doesn't have clean output after this patch because
ConsoleSocket isn't converted yet. But then, technically the commit
message doesn't make this claim, and you can indeed check the
self-consistency when you ignore the ConsoleSocket related errors, so
probably not a problem.

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Whoops, old commit message.

I decided against folding in the new changes because they are newer and have been through the review wringer a lot less.

I'll fix this commit message up.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]