[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/25] block/nvme: Trace queue pair creation/deletion
From: |
Auger Eric |
Subject: |
Re: [PATCH 07/25] block/nvme: Trace queue pair creation/deletion |
Date: |
Wed, 28 Oct 2020 11:28:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Philippe,
On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> block/nvme.c | 3 +++
> block/trace-events | 2 ++
> 2 files changed, 5 insertions(+)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 29d2541b911..e95d59d3126 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -181,6 +181,7 @@ static void nvme_init_queue(BDRVNVMeState *s, NVMeQueue
> *q,
>
> static void nvme_free_queue_pair(NVMeQueuePair *q)
> {
> + trace_nvme_free_queue_pair(q->index, q);
> if (q->completion_bh) {
> qemu_bh_delete(q->completion_bh);
> }
> @@ -216,6 +217,8 @@ static NVMeQueuePair
> *nvme_create_queue_pair(BDRVNVMeState *s,
> if (!q) {
> return NULL;
> }
> + trace_nvme_create_queue_pair(idx, q, size, aio_context,
> + event_notifier_get_fd(s->irq_notifier));
> q->prp_list_pages = qemu_try_memalign(s->page_size,
> s->page_size * NVME_NUM_REQS);
> if (!q->prp_list_pages) {
> diff --git a/block/trace-events b/block/trace-events
> index cc5e2b55cb5..f6a0f99df1a 100644
> --- a/block/trace-events
> +++ b/block/trace-events
> @@ -155,6 +155,8 @@ nvme_dsm(void *s, uint64_t offset, uint64_t bytes) "s %p
> offset 0x%"PRIx64" byte
> nvme_dsm_done(void *s, uint64_t offset, uint64_t bytes, int ret) "s %p
> offset 0x%"PRIx64" bytes %"PRId64" ret %d"
> nvme_dma_map_flush(void *s) "s %p"
> nvme_free_req_queue_wait(void *s, unsigned q_index) "s %p q #%u"
> +nvme_create_queue_pair(unsigned q_index, void *q, unsigned size, void
> *aio_context, int fd) "index %u q %p size %u aioctx %p fd %d"
> +nvme_free_queue_pair(unsigned q_index, void *q) "index %u q %p"
> nvme_cmd_map_qiov(void *s, void *cmd, void *req, void *qiov, int entries) "s
> %p cmd %p req %p qiov %p entries %d"
> nvme_cmd_map_qiov_pages(void *s, int i, uint64_t page) "s %p page[%d]
> 0x%"PRIx64
> nvme_cmd_map_qiov_iov(void *s, int i, void *page, int pages) "s %p iov[%d]
> %p pages %d"
>
- [PATCH 05/25] block/nvme: Trace nvme_poll_queue() per queue, (continued)
- [PATCH 05/25] block/nvme: Trace nvme_poll_queue() per queue, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 09/25] block/nvme: Move definitions before structure declarations, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 07/25] block/nvme: Trace queue pair creation/deletion, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 10/25] block/nvme: Use unsigned integer for queue counter/size, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 08/25] block/nvme: Simplify device reset, Philippe Mathieu-Daudé, 2020/10/27