[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indica
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error |
|
Date: |
Wed, 28 Oct 2020 15:07:57 +0000 |
On Wed, Oct 28, 2020 at 12:03:00PM +0100, Auger Eric wrote:
> On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote:
> > Just for consistency, following the example documented since
> > commit e3fe3988d7 ("error: Document Error API usage rules"),
> > return a boolean value indicating an error is set or not.
> Then I think the returned value should be used by the caller in this patch
Yes, please.
Stefan
signature.asc
Description: PGP signature
- [PATCH 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information, (continued)
- [PATCH 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 09/25] block/nvme: Move definitions before structure declarations, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 07/25] block/nvme: Trace queue pair creation/deletion, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 10/25] block/nvme: Use unsigned integer for queue counter/size, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 08/25] block/nvme: Simplify device reset, Philippe Mathieu-Daudé, 2020/10/27
[PATCH 12/25] block/nvme: Make nvme_init_queue() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/27