[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 31/44] qdev: Reuse object_property_add_field() when adding arr
From: |
Eduardo Habkost |
Subject: |
[PATCH v2 31/44] qdev: Reuse object_property_add_field() when adding array elements |
Date: |
Wed, 4 Nov 2020 11:00:08 -0500 |
Now that we can call object_property_add() with exactly the same
arguments as object_property_add_field(), we can just reuse the
function.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* Now we don't need to hack ObjectProperty.release anymore,
patch became trivial
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
hw/core/qdev-properties.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 0aa482b3ab..5faf974c4f 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -574,12 +574,7 @@ static void set_prop_arraylen(Object *obj, Visitor *v,
const char *name,
*/
arrayprop->offset = eltptr - (void *)obj;
assert(qdev_get_prop_ptr(obj, arrayprop) == eltptr);
- object_property_add(obj, propname,
- arrayprop->info->name,
- field_prop_getter(arrayprop->info),
- field_prop_setter(arrayprop->info),
- arrayprop->info->release,
- arrayprop);
+ object_property_add_field(obj, propname, arrayprop);
}
}
--
2.28.0
- [PATCH v2 13/44] qdev: Move UUID property to qdev-properties-system.c, (continued)
- [PATCH v2 13/44] qdev: Move UUID property to qdev-properties-system.c, Eduardo Habkost, 2020/11/04
- [PATCH v2 11/44] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/11/04
- [PATCH v2 16/44] sparc: Use DEFINE_PROP for nwindows property, Eduardo Habkost, 2020/11/04
- [PATCH v2 17/44] qdev: Get just property name at error_set_from_qdev_prop_error(), Eduardo Habkost, 2020/11/04
- [PATCH v2 12/44] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/11/04
- [PATCH v2 21/44] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/11/04
- [PATCH v2 15/44] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/11/04
- [PATCH v2 28/44] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen(), Eduardo Habkost, 2020/11/04
- [PATCH v2 39/44] qdev: PROP_* macros, Eduardo Habkost, 2020/11/04
- [PATCH v2 32/44] qom: Add allow_set callback to ObjectProperty, Eduardo Habkost, 2020/11/04
- [PATCH v2 31/44] qdev: Reuse object_property_add_field() when adding array elements,
Eduardo Habkost <=
- [PATCH v2 18/44] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/11/04
- [PATCH v2 22/44] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/11/04
- [PATCH v2 27/44] qdev: Don't set qdev_prop_name for array elements, Eduardo Habkost, 2020/11/04
- [PATCH v2 29/44] qdev: Remove ArrayElementProperty.propname field, Eduardo Habkost, 2020/11/04
- [PATCH v2 40/44] qdev: Move core field property code to QOM, Eduardo Habkost, 2020/11/04
- [PATCH v2 23/44] qdev: Make PropertyInfo.create return ObjectProperty*, Eduardo Habkost, 2020/11/04
- [PATCH v2 26/44] qdev: Rename Property.name to Property.qdev_prop_name, Eduardo Habkost, 2020/11/04
- [PATCH v2 33/44] qdev: Make qdev_prop_allow_set() a ObjectProperty.allow_set callback, Eduardo Habkost, 2020/11/04