|
From: | Paolo Bonzini |
Subject: | Re: [RFC v1 09/10] i386: split cpu.c and defer x86 models registration |
Date: | Tue, 10 Nov 2020 21:39:37 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 10/11/20 18:55, Eduardo Habkost wrote:
I think we should not try yo implement interfaces conditionally (i.e. have TYPE_X86_ACCEL implemented only on qemu-system-{i386,x86_64} and not qemu-system-arm), even if technically the accel/ objects are per-target (specific_ss) rather than common.If the accel objects are already per target, it seems appropriate to have a QOM type hierarchy that reflects that. `qemu-system-x86_64 -accel kvm` would create a kvm-x86_64-accel object, but `qemu-system-arm -accel kvm` would create a kvm-arm-accel.
... and fall back to kvm-accel? So accel_find would be the only place to change.
Paolo
*-x86_64-accel and *-i386-accel would all implement INTERFACE_X86_ACCEL.
[Prev in Thread] | Current Thread | [Next in Thread] |