[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg
From: |
Cornelia Huck |
Subject: |
Re: [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg |
Date: |
Fri, 13 Nov 2020 12:23:51 +0100 |
On Thu, 12 Nov 2020 16:43:06 -0500
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> - Fix build error with CONFIG_XEN
> I took the liberty of keeping the Reviewed-by line from
> Marc-André as the build fix is a trivial one line change
> ---
> Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Paul Durrant <paul@xen.org>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Matthew Rosato <mjrosato@linux.ibm.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: qemu-devel@nongnu.org
> Cc: xen-devel@lists.xenproject.org
> Cc: qemu-block@nongnu.org
> Cc: qemu-s390x@nongnu.org
> ---
> include/hw/qdev-properties.h | 2 +-
> backends/tpm/tpm_util.c | 8 ++--
> hw/block/xen-block.c | 5 +-
> hw/core/qdev-properties-system.c | 57 +++++++++-------------
> hw/core/qdev-properties.c | 82 +++++++++++++-------------------
> hw/s390x/css.c | 5 +-
> hw/s390x/s390-pci-bus.c | 4 +-
> hw/vfio/pci-quirks.c | 5 +-
> 8 files changed, 68 insertions(+), 100 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com> #s390 parts
- [PATCH v3 02/53] cpu: Move cpu_common_props to hw/core/cpu.c, (continued)
- [PATCH v3 02/53] cpu: Move cpu_common_props to hw/core/cpu.c, Eduardo Habkost, 2020/11/12
- [PATCH v3 03/53] qdev: Move property code to qdev-properties.[ch], Eduardo Habkost, 2020/11/12
- [PATCH v3 04/53] qdev: Check dev->realized at set_size(), Eduardo Habkost, 2020/11/12
- [PATCH v3 08/53] qdev: Make bit_prop_set() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 07/53] qdev: Make PropertyInfo.print method get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 05/53] sparc: Check dev->realized at sparc_set_nwindows(), Eduardo Habkost, 2020/11/12
- [PATCH v3 06/53] qdev: Don't use dev->id on set_size32() error message, Eduardo Habkost, 2020/11/12
- [PATCH v3 10/53] qdev: Make qdev_find_global_prop() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 11/53] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg, Eduardo Habkost, 2020/11/12
- Re: [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg,
Cornelia Huck <=
- [PATCH v3 12/53] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/11/12
- [PATCH v3 13/53] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/11/12
- [PATCH v3 14/53] qdev: Move UUID property to qdev-properties-system.c, Eduardo Habkost, 2020/11/12
- [PATCH v3 17/53] sparc: Use DEFINE_PROP for nwindows property, Eduardo Habkost, 2020/11/12
- [PATCH v3 16/53] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/11/12
- [PATCH v3 15/53] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/11/12
- [PATCH v3 18/53] qdev: Get just property name at error_set_from_qdev_prop_error(), Eduardo Habkost, 2020/11/12
- [PATCH v3 19/53] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/11/12
- [PATCH v3 20/53] qdev: Add name parameter to qdev_class_add_property(), Eduardo Habkost, 2020/11/12