qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] python, tests: do not use short-form boolean options


From: Markus Armbruster
Subject: Re: [PATCH] python, tests: do not use short-form boolean options
Date: Tue, 17 Nov 2020 10:20:47 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Paolo Bonzini <pbonzini@redhat.com> writes:

> They are going to be deprecated, avoid warnings on stdout while the
> tests run.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  python/qemu/machine.py               | 2 +-
>  tests/qtest/pflash-cfi02-test.c      | 4 ++--
>  tests/qtest/test-filter-redirector.c | 8 ++++----
>  tests/qtest/vhost-user-test.c        | 8 ++++----
>  tests/test-char.c                    | 8 ++++----
>  5 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/python/qemu/machine.py b/python/qemu/machine.py
> index 6420f01bed..06e3e22935 100644
> --- a/python/qemu/machine.py
> +++ b/python/qemu/machine.py
> @@ -292,7 +292,7 @@ class QEMUMachine:
>          for _ in range(self._console_index):
>              args.extend(['-serial', 'null'])
>          if self._console_set:
> -            chardev = ('socket,id=console,path=%s,server,nowait' %
> +            chardev = ('socket,id=console,path=%s,server=yes,wait=no' %

Let's stick to the canonical 'on' and 'off'.

>                         self._console_address)
>              args.extend(['-chardev', chardev])
>              if self._console_device_type is None:
[More of the same...]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]