[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] python, tests: do not use short-form boolean options
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] python, tests: do not use short-form boolean options |
|
Date: |
Tue, 17 Nov 2020 15:32:02 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 17/11/20 10:20, Markus Armbruster wrote:
>>> - chardev = ('socket,id=console,path=%s,server,nowait' %
>>> + chardev = ('socket,id=console,path=%s,server=yes,wait=no' %
>>
>> Let's stick to the canonical 'on' and 'off'.
>
> That was on purpose (for extra coverage and not just because variety is
> the spice of life). But I can use the canonical values as well if you
> prefer.
I think the place for extra coverage is tests/test-qemu-opts.c.