[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/26] target/mips: Extract Loongson SIMD translation routine
From: |
Richard Henderson |
Subject: |
Re: [PATCH 18/26] target/mips: Extract Loongson SIMD translation routines |
Date: |
Sat, 21 Nov 2020 12:09:24 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/21/20 6:30 AM, Philippe Mathieu-Daudé wrote:
>> -/* Godson integer instructions */
>> -static void gen_loongson_integer(DisasContext *ctx, uint32_t opc,
>> - int rd, int rs, int rt)
>> -{
>
> This isn't part of the LoongSIMD ...
>
> [...]
>> -}
>> -
>> -/* Loongson multimedia instructions */
>> -static void gen_loongson_multimedia(DisasContext *ctx, int rd, int rs, int
>> rt)
>> -{
> [...]
>
> ... but this part is.
>
With gen_loongson_integer not moved,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH 14/26] target/mips: Extract NEC Vr54xx helper definitions, (continued)
- [PATCH 14/26] target/mips: Extract NEC Vr54xx helper definitions, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 15/26] target/mips: Extract NEC Vr54xx translation routines, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 17/26] target/mips: Extract Loongson SIMD helper definitions, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 16/26] target/mips: Rename lmmi_helper.c as loong-simd_helper.c, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 18/26] target/mips: Extract Loongson SIMD translation routines, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 19/26] target/mips: Extract Loongson EXTensions translation routines, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 20/26] target/mips: Extract XBurst Media eXtension Unit translation routines, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 21/26] target/mips: Make pipeline 1 multiply opcodes generic, Philippe Mathieu-Daudé, 2020/11/20
- [PATCH 22/26] target/mips: Extract Toshiba TXx9 translation routines, Philippe Mathieu-Daudé, 2020/11/20