qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 20/26] target/mips: Extract XBurst Media eXtension Unit trans


From: Richard Henderson
Subject: Re: [PATCH 20/26] target/mips: Extract XBurst Media eXtension Unit translation routines
Date: Sat, 21 Nov 2020 12:13:16 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 11/20/20 1:08 PM, Philippe Mathieu-Daudé wrote:
> Media eXtension Unit is a SIMD extension from Ingenic.
> 
> Extract 2900 lines from the huge translate.c to a new file,
> 'vendor-xburst_translate.c.inc'. As there are too many inter-
> dependencies we don't compile it as another object, but
> keep including it in the big translate.o. We gain in code
> maintainability.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/mips/translate.c                   | 2890 +-------------------
>  target/mips/vendor-xburst_translate.c.inc | 2893 +++++++++++++++++++++
>  2 files changed, 2894 insertions(+), 2889 deletions(-)
>  create mode 100644 target/mips/vendor-xburst_translate.c.inc

Where does the xburst name come from?
It's a little confusing that all of the comments talk about MXU but the
filename is xburst.  Perhaps add a comment near the top identifying the rename,
if you can?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]