[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 21/32] qdev: Add name argument to PropertyInfo.create meth
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v4 21/32] qdev: Add name argument to PropertyInfo.create method |
Date: |
Mon, 14 Dec 2020 15:47:43 +0100 |
On Fri, 11 Dec 2020 17:05:18 -0500
Eduardo Habkost <ehabkost@redhat.com> wrote:
> This will make it easier to remove the Property.name field in the
> future.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> This is a new patch added in series v2
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> include/hw/qdev-properties.h | 2 +-
> hw/core/qdev-properties.c | 7 ++++---
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 476737b9da..ab9c538ba4 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -34,7 +34,7 @@ struct PropertyInfo {
> const QEnumLookup *enum_table;
> int (*print)(Object *obj, Property *prop, char *dest, size_t len);
> void (*set_default_value)(ObjectProperty *op, const Property *prop);
> - void (*create)(ObjectClass *oc, Property *prop);
> + void (*create)(ObjectClass *oc, const char *name, Property *prop);
> ObjectPropertyAccessor *get;
> ObjectPropertyAccessor *set;
> ObjectPropertyRelease *release;
> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
> index 457c7fe4ba..c68a20695d 100644
> --- a/hw/core/qdev-properties.c
> +++ b/hw/core/qdev-properties.c
> @@ -851,9 +851,10 @@ const PropertyInfo qdev_prop_size = {
>
> /* --- object link property --- */
>
> -static void create_link_property(ObjectClass *oc, Property *prop)
> +static void create_link_property(ObjectClass *oc, const char *name,
> + Property *prop)
> {
> - object_class_property_add_link(oc, prop->name, prop->link_type,
> + object_class_property_add_link(oc, name, prop->link_type,
> prop->offset,
> qdev_prop_allow_set_link_before_realize,
> OBJ_PROP_LINK_STRONG);
> @@ -893,7 +894,7 @@ static void qdev_class_add_property(DeviceClass *klass,
> const char *name,
> ObjectClass *oc = OBJECT_CLASS(klass);
>
> if (prop->info->create) {
> - prop->info->create(oc, prop);
> + prop->info->create(oc, name, prop);
> } else {
> ObjectProperty *op;
>
- Re: [PATCH v4 18/32] qdev: Get just property name at error_set_from_qdev_prop_error(), (continued)
- [PATCH v4 19/32] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/12/11
- [PATCH v4 15/32] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/12/11
- [PATCH v4 20/32] qdev: Add name parameter to qdev_class_add_property(), Eduardo Habkost, 2020/12/11
- [PATCH v4 21/32] qdev: Add name argument to PropertyInfo.create method, Eduardo Habkost, 2020/12/11
- Re: [PATCH v4 21/32] qdev: Add name argument to PropertyInfo.create method,
Igor Mammedov <=
- [PATCH v4 22/32] qdev: Wrap getters and setters in separate helpers, Eduardo Habkost, 2020/12/11
- [PATCH v4 24/32] qdev: Make PropertyInfo.create return ObjectProperty*, Eduardo Habkost, 2020/12/11
- [PATCH v4 25/32] qdev: Make qdev_class_add_property() more flexible, Eduardo Habkost, 2020/12/11
- [PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set(), Eduardo Habkost, 2020/12/11