[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property |
Date: |
Tue, 15 Dec 2020 15:39:07 +0100 |
On Mon, 14 Dec 2020 12:30:13 -0500
Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Mon, Dec 14, 2020 at 03:42:48PM +0100, Igor Mammedov wrote:
> > On Fri, 11 Dec 2020 17:05:14 -0500
> > Eduardo Habkost <ehabkost@redhat.com> wrote:
> >
> > > Use the DEFINE_PROP macro (which will set extra fields in the
> > > struct) instead of initializing a Property struct manually.
> > >
> > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > > ---
> > > This is a new patch added in v2 of the series
> > > ---
> > > Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > > Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> > > Cc: qemu-devel@nongnu.org
> > > ---
> > > target/sparc/cpu.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
> > > index 6a3299041f..92534bcd18 100644
> > > --- a/target/sparc/cpu.c
> > > +++ b/target/sparc/cpu.c
> > > @@ -848,7 +848,8 @@ static Property sparc_cpu_properties[] = {
> > > qdev_prop_uint64, target_ulong),
> > > DEFINE_PROP_UINT32("fpu-version", SPARCCPU, env.def.fpu_version, 0),
> > > DEFINE_PROP_UINT32("mmu-version", SPARCCPU, env.def.mmu_version, 0),
> > > - { .name = "nwindows", .info = &qdev_prop_nwindows },
> > > + DEFINE_PROP("nwindows", SPARCCPU, env.def.nwindows,
> > ^^^^
> > stray whitespace
>
> I was trying to keep it aligned to the other entries (not visible in diff
> context), but I agree it's just confusing. I will fix this while committing.
>
With that
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
- [PATCH v4 10/32] qdev: Make qdev_find_global_prop() get Object* argument, (continued)
- [PATCH v4 10/32] qdev: Make qdev_find_global_prop() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 12/32] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 13/32] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/12/11
- [PATCH v4 14/32] qdev: Move UUID property to qdev-properties-system.c, Eduardo Habkost, 2020/12/11
- [PATCH v4 16/32] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/12/11
- [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property, Eduardo Habkost, 2020/12/11
- Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property, Mark Cave-Ayland, 2020/12/15
- [PATCH v4 18/32] qdev: Get just property name at error_set_from_qdev_prop_error(), Eduardo Habkost, 2020/12/11
- [PATCH v4 19/32] qdev: Avoid using prop->name unnecessarily, Eduardo Habkost, 2020/12/11
- [PATCH v4 15/32] qdev: Move softmmu properties to qdev-properties-system.h, Eduardo Habkost, 2020/12/11