[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/9] meson: Clarify summary

From: Paolo Bonzini
Subject: Re: [PATCH 0/9] meson: Clarify summary
Date: Wed, 20 Jan 2021 18:10:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 19/01/21 19:49, Philippe Mathieu-Daudé wrote:
Reorder stuffs in summary to quicker understand bug reports.

Remove information from deselected features when not necessary.

Philippe Mathieu-Daudé (9):
   meson: Summarize generic information first
   meson: Summarize compilation information altogether
   meson: Summarize host binaries altogether
   meson: Summarize accelerators altogether
   meson: Display if system emulation is selected in summary
   meson: Restrict system-mode specific accelerators
   meson: Do not configure audio if system-mode is not selected
   meson: Display if user-mode emulation is selected in summary
   meson: Summarize block layer information altogether

  configure   |   6 +++
  meson.build | 132 +++++++++++++++++++++++++++++-----------------------
  2 files changed, 81 insertions(+), 57 deletions(-)

Very nice. (I'm just not sure about patches 5 and 8 since there's already the target directories). A couple nits:

* sparse should go in host binaries

* WIN_SDK should go in compilation information

* It would be nice to have a comment above each of the groups

I have done the changes myself. I will also send out for review a patch to further group dependencies and "other features" (vhost, modules, etc.).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]