[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 1/4] hw/ide/Kconfig: IDE_ISA requires ISA_BUS

From: Paolo Bonzini
Subject: Re: [RFC PATCH 1/4] hw/ide/Kconfig: IDE_ISA requires ISA_BUS
Date: Fri, 29 Jan 2021 20:59:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 29/01/21 20:44, Philippe Mathieu-Daudé wrote:
hw/ide/ioport.c has a strong dependency on hw/isa/isa-bus.c:

   /usr/bin/ld: libcommon.fa.p/hw_ide_ioport.c.o: in function `ide_init_ioport':
   /usr/bin/ld: hw/ide/ioport.c:61: undefined reference to 

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
  hw/ide/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
index 5d9106b1ac2..41cdd9cbe03 100644
--- a/hw/ide/Kconfig
+++ b/hw/ide/Kconfig
@@ -12,7 +12,7 @@ config IDE_PCI
config IDE_ISA
-    depends on ISA_BUS
+    select ISA_BUS
      select IDE_QDEV
config IDE_PIIX

This is incorrect. Buses are "depended on", not selected, and this is documented in docs/devel/kconfig.rst.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]