[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be cha
Re: [PATCH v4 2/5] acpi: Permit OEM ID and OEM table ID fields to be changed
Sun, 07 Feb 2021 20:23:33 +0200
"Michael S. Tsirkin" <email@example.com> writes:
> I queued this but there's a lot of code duplication with this.
> Further, the use of g_strdup adds unnecessary dynamic memory
> management where it's not needed.
> I'd prefer
> - a new struct AcpiBuildOem including the correct strings
> - use sizeof of fields in above instead of 8/6
> - move shared strings and code into a common header
So how should I approach this since the patches are queued? A new patch
with the suggested changes, or resending the original patches?