[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 10/31] linux-user: Fix guest_addr_valid vs reserved_va
From: |
Richard Henderson |
Subject: |
[PATCH v7 10/31] linux-user: Fix guest_addr_valid vs reserved_va |
Date: |
Fri, 12 Feb 2021 10:48:41 -0800 |
We must always use GUEST_ADDR_MAX, because even 32-bit hosts can
use -R <reserved_va> to restrict the memory address of the guest.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/cpu_ldst.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
index 4e6ef3d542..e62f4fba00 100644
--- a/include/exec/cpu_ldst.h
+++ b/include/exec/cpu_ldst.h
@@ -72,11 +72,10 @@ typedef uint64_t abi_ptr;
/* All direct uses of g2h and h2g need to go away for usermode softmmu. */
#define g2h(x) ((void *)((uintptr_t)(abi_ptr)(x) + guest_base))
-#if HOST_LONG_BITS <= TARGET_VIRT_ADDR_SPACE_BITS
-#define guest_addr_valid(x) (1)
-#else
-#define guest_addr_valid(x) ((x) <= GUEST_ADDR_MAX)
-#endif
+static inline bool guest_addr_valid(abi_ulong x)
+{
+ return x <= GUEST_ADDR_MAX;
+}
static inline bool guest_range_valid(abi_ulong start, abi_ulong len)
{
--
2.25.1
- Re: [PATCH v7 05/31] exec: Improve types for guest_addr_valid, (continued)
- [PATCH v7 04/31] exec: Use uintptr_t in cpu_ldst.h, Richard Henderson, 2021/02/12
- [PATCH v7 08/31] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/02/12
- [PATCH v7 13/31] linux-user: Explicitly untag memory management syscalls, Richard Henderson, 2021/02/12
- [PATCH v7 09/31] linux-user: Do not use guest_addr_valid for h2g_valid, Richard Henderson, 2021/02/12
- [PATCH v7 07/31] linux-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/02/12
- [PATCH v7 12/31] exec: Use cpu_untagged_addr in g2h; split out g2h_untagged, Richard Henderson, 2021/02/12
- [PATCH v7 15/31] exec: Rename guest_{addr,range}_valid to *_untagged, Richard Henderson, 2021/02/12
- [PATCH v7 11/31] exec: Introduce cpu_untagged_addr, Richard Henderson, 2021/02/12
- [PATCH v7 10/31] linux-user: Fix guest_addr_valid vs reserved_va,
Richard Henderson <=
- [PATCH v7 22/31] target/arm: Use the proper TBI settings for linux-user, Richard Henderson, 2021/02/12
- [PATCH v7 19/31] linux-user: Handle tags in lock_user/unlock_user, Richard Henderson, 2021/02/12
- [PATCH v7 06/31] linux-user: Check for overflow in access_ok, Richard Henderson, 2021/02/12
- [PATCH v7 16/31] linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged, Richard Henderson, 2021/02/12
- [PATCH v7 17/31] linux-user: Move lock_user et al out of line, Richard Henderson, 2021/02/12
- [PATCH v7 14/31] linux-user: Use guest_range_valid in access_ok, Richard Henderson, 2021/02/12
- [PATCH v7 20/31] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE, Richard Henderson, 2021/02/12
- [PATCH v7 18/31] linux-user: Fix types in uaccess.c, Richard Henderson, 2021/02/12