[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 14/23] tests/plugin: expand insn test to detect duplicate

From: Richard Henderson
Subject: Re: [PATCH v3 14/23] tests/plugin: expand insn test to detect duplicate instructions
Date: Sat, 13 Feb 2021 08:26:10 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 2/13/21 5:03 AM, Alex Bennée wrote:
> A duplicate insn is one that is appears to be executed twice in a row.
> This is currently possible due to -icount and cpu_io_recompile()
> causing a re-translation of a block. On it's own this won't trigger
> any tests though.
> The heuristics that the plugin use can't deal with the x86 rep
> instruction which (validly) will look like executing the same
> instruction several times. To avoid problems later we tweak the rules
> for x86 to run the "inline" version of the plugin. This also has the
> advantage of increasing coverage of the plugin code (see bugfix in
> previous commit).
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20210209182749.31323-6-alex.bennee@linaro.org>
> Message-Id: <20210210221053.18050-15-alex.bennee@linaro.org>
> ---
>  tests/plugin/insn.c                      | 12 +++++++++++-
>  tests/tcg/i386/Makefile.softmmu-target   | 10 ++++++++++
>  tests/tcg/i386/Makefile.target           |  7 +++++++
>  tests/tcg/x86_64/Makefile.softmmu-target | 10 ++++++++++
>  4 files changed, 38 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]