[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V2 4/7] block/rbd: add bdrv_attach_aio_context

From: Peter Lieven
Subject: Re: [PATCH V2 4/7] block/rbd: add bdrv_attach_aio_context
Date: Mon, 15 Feb 2021 12:48:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

Am 15.02.21 um 11:20 schrieb Kevin Wolf:
Am 26.01.2021 um 12:25 hat Peter Lieven geschrieben:
Signed-off-by: Peter Lieven <pl@kamp.de>
  block/rbd.c | 15 +++++++++++++--
  1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/block/rbd.c b/block/rbd.c
index f68ebcf240..7abd0252c9 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -91,6 +91,7 @@ typedef struct BDRVRBDState {
      char *namespace;
      uint64_t image_size;
      uint64_t object_size;
+    AioContext *aio_context;
  } BDRVRBDState;
A commit message explaining the why would be helpful here.

This is already stored in BlockDriverState, which should be available
everywhere. Keeping redundant information needs a good justification,
which seems unlikely when BlockDriverState and BDRVRBDState are already
connected through the BlockDriverState.opaque pointer.

The rest of the series doesn't seem to make more use of it either.

You are right. I was not aware that the aio_context is already there.

We keep a local copy of aio_context in iscsi and nfs driver as well. That

is where I got it from. I will change it if we don't drop the series completely.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]