[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v18 00/15] i386 cleanup PART 2
From: |
Claudio Fontana |
Subject: |
Re: [RFC v18 00/15] i386 cleanup PART 2 |
Date: |
Mon, 15 Feb 2021 12:48:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 2/15/21 12:37 PM, Alex Bennée wrote:
>
> Claudio Fontana <cfontana@suse.de> writes:
>
> <snip>
>> Looking forward to your comments on this proposal,
>>
> <snip>
>
> So I've reviewed as much as I'm comfortable with - I'm going to defer to
> the x86 experts on the split of stuff for x86. However from my point of
> view I think it's a nice step in improving modularity and reducing the
> maze of #ifdefs in the code.
>
Thanks a lot Alex for your review.
If I can leverage your TCG knowledge a bit more, as I forgot a lot about it,
have you noticed in "i386: split tcg btp_helper into softmmu and user parts"
and "i386: split smm helper (softmmu)"
those new
#ifndef CONFIG_USER_ONLY?
Basically we remove some preamble stuff that would end up calling empty stubs
for user mode,
but do you think there could be some other consequence I am not seeing?
Maybe there is even more that could be removed in the code immediately
preceding those CONFIG_USER_ONLY?
In particular I am referring to patches:
i386: split tcg btp_helper into softmmu and user parts
i386: split smm helper (softmmu)
I am commenting those patches now inline, so that it is easier to see what I am
talking about.
Again, thanks a lot!
Claudio
- [RFC v18 05/15] accel-cpu: make cpu_realizefn return a bool, (continued)
- [RFC v18 05/15] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/02/12
- [RFC v18 12/15] i386: separate fpu_helper into user and softmmu parts, Claudio Fontana, 2021/02/12
- [RFC v18 11/15] i386: split misc helper into user and softmmu parts, Claudio Fontana, 2021/02/12
- [RFC v18 09/15] i386: split tcg excp_helper into softmmu and user parts, Claudio Fontana, 2021/02/12
- [RFC v18 14/15] i386: split seg_helper into user-only and softmmu parts, Claudio Fontana, 2021/02/12
- [RFC v18 15/15] i386: split off softmmu part of cpu.c, Claudio Fontana, 2021/02/12
- [RFC v18 13/15] i386: slit svm_helper into softmmu and stub-only user, Claudio Fontana, 2021/02/12
- Re: [RFC v18 00/15] i386 cleanup PART 2, no-reply, 2021/02/12
- Re: [RFC v18 00/15] i386 cleanup PART 2, Alex Bennée, 2021/02/15
- Re: [RFC v18 00/15] i386 cleanup PART 2,
Claudio Fontana <=