[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RESEND] hostmem: Don't report pmem attribute if unsupported

From: Michal Privoznik
Subject: Re: [PATCH RESEND] hostmem: Don't report pmem attribute if unsupported
Date: Mon, 15 Feb 2021 13:34:05 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 1/26/21 8:48 AM, Michal Privoznik wrote:
When management applications (like Libvirt) want to check whether
memory-backend-file.pmem is supported they can list object
properties using 'qom-list-properties'. However, 'pmem' is
declared always (and thus reported always) and only at runtime
QEMU errors out if it was built without libpmem (and thus can not
guarantee write persistence). This is suboptimal since we have
ability to declare attributes at compile time.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1915216
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

This is just a resend of a patch I've sent earlier with Reviewed-by and
Tested-by added:


  backends/hostmem-file.c | 13 ++++---------
  1 file changed, 4 insertions(+), 9 deletions(-)

Polite ping, please.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]