[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named()

From: Christian Schoenebeck
Subject: Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named()
Date: Mon, 15 Feb 2021 15:06:41 +0100

On Montag, 15. Februar 2021 14:16:16 CET Paolo Bonzini wrote:
> From: qemu_oss--- via <qemu-devel@nongnu.org>
> So far the qos subsystem of the qtest framework had the limitation
> that only one instance of the same official QEMU (QMP) driver name
> could be created for qtests. That's because a) the created qos
> node names must always be unique, b) the node name must match the
> official QEMU driver name being instantiated and c) all nodes are
> in a global space shared by all tests.
> This patch removes this limitation by introducing a new function
> qos_node_create_driver_named() which allows test case authors to
> specify a node name being different from the actual associated
> QEMU driver name. It fills the new 'qemu_name' field of
> QOSGraphNode for that purpose.
> Adjust build_driver_cmd_line() and qos_graph_node_set_availability()
> to correctly deal with either accessing node name vs. node's
> qemu_name correctly.
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> Message-Id:
> <3be962ff38f3396f8040deaa5ffdab525c4e0b16.1611704181.git.qemu_oss@crudebyte
> .com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Just a side note: The odd "From:" line was because of a temporary issue with 
the mailman version running GNU lists, which caused mailman to rewrite certain 
sender addresses. The problem with mailman had been fixed in the meantime.

I personally don't care about it, but just that you know that this did not 
happen by purpose or something.

Best regards,
Christian Schoenebeck

reply via email to

[Prev in Thread] Current Thread [Next in Thread]