[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named()
|
From: |
Christian Schoenebeck |
|
Subject: |
Re: [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named() |
|
Date: |
Thu, 18 Feb 2021 10:23:45 +0100 |
On Donnerstag, 18. Februar 2021 10:14:12 CET Paolo Bonzini wrote:
> On 18/02/21 10:10, Christian Schoenebeck wrote:
> > On Montag, 15. Februar 2021 15:06:41 CET Christian Schoenebeck wrote:
> >> On Montag, 15. Februar 2021 14:16:16 CET Paolo Bonzini wrote:
> >>> From: qemu_oss--- via <qemu-devel@nongnu.org>
> >>>
> >>> So far the qos subsystem of the qtest framework had the limitation
> >>> that only one instance of the same official QEMU (QMP) driver name
> >>> could be created for qtests. That's because a) the created qos
> >>> node names must always be unique, b) the node name must match the
> >>> official QEMU driver name being instantiated and c) all nodes are
> >>> in a global space shared by all tests.
> >>>
> >>> This patch removes this limitation by introducing a new function
> >>> qos_node_create_driver_named() which allows test case authors to
> >>> specify a node name being different from the actual associated
> >>> QEMU driver name. It fills the new 'qemu_name' field of
> >>> QOSGraphNode for that purpose.
> >>>
> >>> Adjust build_driver_cmd_line() and qos_graph_node_set_availability()
> >>> to correctly deal with either accessing node name vs. node's
> >>> qemu_name correctly.
> >>>
> >>> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> >>> Message-Id:
> >>> <3be962ff38f3396f8040deaa5ffdab525c4e0b16.1611704181.git.qemu_oss@crudeb
> >>> yt
> >>> e
> >>> .com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>
> >> Just a side note: The odd "From:" line was because of a temporary issue
> >> with the mailman version running GNU lists, which caused mailman to
> >> rewrite certain sender addresses. The problem with mailman had been
> >> fixed in the meantime.
> >>
> >> I personally don't care about it, but just that you know that this did
> >> not
> >> happen by purpose or something.
> >
> > Paolo, do you want me to resend these patches as v2 for fixing the author
> > rewrite issue?
>
> The patches already in and with the right author.
>
> Paolo
Right, I just noticed that. Sorry Paolo for the trouble. :/
Best regards,
Christian Schoenebeck
- [PULL 04/19] sev/i386: Require in-kernel irqchip support for SEV-ES guests, (continued)
- [PULL 04/19] sev/i386: Require in-kernel irqchip support for SEV-ES guests, Paolo Bonzini, 2021/02/15
- [PULL 05/19] sev/i386: Allow AP booting under SEV-ES, Paolo Bonzini, 2021/02/15
- [PULL 06/19] sev/i386: Don't allow a system reset under an SEV-ES guest, Paolo Bonzini, 2021/02/15
- [PULL 07/19] kvm/i386: Use a per-VM check for SMM capability, Paolo Bonzini, 2021/02/15
- [PULL 10/19] libqos/qgraph_internal: add qos_printf() and qos_printf_literal(), Paolo Bonzini, 2021/02/15
- [PULL 08/19] sev/i386: Enable an SEV-ES guest based on SEV policy, Paolo Bonzini, 2021/02/15
- [PULL 09/19] libqos/qgraph: add qos_node_create_driver_named(), Paolo Bonzini, 2021/02/15
[PULL 11/19] tests/qtest/qos-test: dump qos graph if verbose, Paolo Bonzini, 2021/02/15
[PULL 13/19] tests/qtest/qos-test: dump QEMU command if verbose, Paolo Bonzini, 2021/02/15
[PULL 12/19] tests/qtest/qos-test: dump environment variables if verbose, Paolo Bonzini, 2021/02/15
[PULL 14/19] util/cutils: Skip "." when looking for next directory component, Paolo Bonzini, 2021/02/15
[PULL 17/19] hvf: x86: Remove unused definitions, Paolo Bonzini, 2021/02/15
[PULL 15/19] hvf: Guard xgetbv call, Paolo Bonzini, 2021/02/15
[PULL 16/19] target/i386/hvf: add vmware-cpuid-freq cpu feature, Paolo Bonzini, 2021/02/15
[PULL 18/19] target/i386/hvf: add rdmsr 35H MSR_CORE_THREAD_COUNT, Paolo Bonzini, 2021/02/15
[PULL 19/19] hvf: Fetch cr4 before evaluating CPUID(1), Paolo Bonzini, 2021/02/15
Re: [PULL 00/19] i386, qgraph patches for 2020-02-15, Thomas Huth, 2021/02/15