[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/35] hexagon initial commit
From: |
no-reply |
Subject: |
Re: [PULL 00/35] hexagon initial commit |
Date: |
Wed, 17 Feb 2021 16:19:16 -0800 (PST) |
Patchew URL:
20210217234023.1742406-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20210217234023.1742406-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210217234023.1742406-1-richard.henderson@linaro.org
Subject: [PULL 00/35] hexagon initial commit
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20210217234023.1742406-1-richard.henderson@linaro.org ->
patchew/20210217234023.1742406-1-richard.henderson@linaro.org
Switched to a new branch 'test'
98e192b Hexagon build infrastructure
5796dfe Hexagon (tests/tcg/hexagon) TCG tests - floating point
5b0fe95 Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc
913d305 Hexagon (tests/tcg/hexagon) TCG tests - multiarch
c3bb4a8 Hexagon (linux-user/hexagon) Linux user emulation
6a6f450 Hexagon (target/hexagon) translation
e1b7dd6 Hexagon (target/hexagon) TCG for floating point instructions
f1052bc Hexagon (target/hexagon) TCG for instructions with multiple definitions
5536087 Hexagon (target/hexagon) TCG generation
f31557d Hexagon (target/hexagon) instruction classes
005ab9b Hexagon (target/hexagon) macros
81ebb54 Hexagon (target/hexagon) opcode data structures
2b3ac85 Hexagon (target/hexagon) generater phase 4 - decode tree
dba3c77 Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode
tree
57a4f7c Hexagon (target/hexagon) generator phase 2 - generate header files
c47298e Hexagon (target/hexagon) generator phase 1 - C preprocessor for
semantics
cb967e8 Hexagon (target/hexagon/imported) arch import
e754350e3 Hexagon (target/hexagon/fma_emu.[ch]) utility functions
47b9ef0 Hexagon (target/hexagon/conv_emu.[ch]) utility functions
711b45d Hexagon (target/hexagon/arch.[ch]) utility functions
6f95889 Hexagon (target/hexagon) instruction printing
df05d4d Hexagon (target/hexagon) instruction/packet decode
ab4e8e3 Hexagon (target/hexagon) instruction attributes
bc6d95f Hexagon (target/hexagon) register fields
49f418a Hexagon (target/hexagon) instruction and packet types
b699f30 Hexagon (target/hexagon) architecture types
f50190c Hexagon (target/hexagon) GDB Stub
0ba17dc Hexagon (target/hexagon) scalar core helpers
e4bd453 Hexagon (target/hexagon) register names
81029f9 Hexagon (disas) disassembler
ca28fd6 Hexagon (target/hexagon) scalar core definition
020a03d Hexagon (include/elf.h) ELF machine definition
5b3dd2c Hexagon (target/hexagon) README
6da0aa0 Hexagon Update MAINTAINERS file
2913e03 qemu/int128: Add int128_or
=== OUTPUT BEGIN ===
1/35 Checking commit 2913e031f873 (qemu/int128: Add int128_or)
2/35 Checking commit 6da0aa05e31c (Hexagon Update MAINTAINERS file)
3/35 Checking commit 5b3dd2c5ca19 (Hexagon (target/hexagon) README)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 235 lines checked
Patch 3/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/35 Checking commit 020a03de90dd (Hexagon (include/elf.h) ELF machine
definition)
5/35 Checking commit ca28fd6b21d7 (Hexagon (target/hexagon) scalar core
definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 599 lines checked
Patch 5/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/35 Checking commit 81029f9e0c0a (Hexagon (disas) disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24:
new file mode 100644
total: 0 errors, 1 warnings, 79 lines checked
Patch 6/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/35 Checking commit e4bd453cff6b (Hexagon (target/hexagon) register names)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
total: 0 errors, 1 warnings, 83 lines checked
Patch 7/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/35 Checking commit 0ba17dcf293a (Hexagon (target/hexagon) scalar core helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 1152 lines checked
Patch 8/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/35 Checking commit f50190c92873 (Hexagon (target/hexagon) GDB Stub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 55 lines checked
Patch 9/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/35 Checking commit b699f30e8dd6 (Hexagon (target/hexagon) architecture types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 38 lines checked
Patch 10/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/35 Checking commit 49f418a843c7 (Hexagon (target/hexagon) instruction and
packet types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 74 lines checked
Patch 11/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/35 Checking commit bc6d95fd0c43 (Hexagon (target/hexagon) register fields)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#87: FILE: target/hexagon/reg_fields.h:29:
+#define DEF_REG_FIELD(TAG, START, WIDTH) \
+ TAG,
total: 1 errors, 1 warnings, 104 lines checked
Patch 12/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/35 Checking commit ab4e8e3e89d1 (Hexagon (target/hexagon) instruction
attributes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#48: FILE: target/hexagon/attribs.h:25:
+#define DEF_ATTRIB(NAME, ...) A_##NAME,
total: 1 errors, 1 warnings, 132 lines checked
Patch 13/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/35 Checking commit df05d4de85b9 (Hexagon (target/hexagon) instruction/packet
decode)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#134: FILE: target/hexagon/decode.c:101:
+#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#640: FILE: target/hexagon/decode.c:607:
+#define DECODE_OPINFO(TAG, BEH) \
+ case TAG: \
+ { BEH } \
+ break; \
+
total: 2 errors, 1 warnings, 989 lines checked
Patch 14/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/35 Checking commit 6f95889de208 (Hexagon (target/hexagon) instruction
printing)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#66: FILE: target/hexagon/printinsn.c:43:
+#define DEF_PRINTINFO(TAG, FMT, ...) \
+ case TAG: \
+ g_string_append_printf(buf, FMT, __VA_ARGS__); \
+ break;
total: 1 errors, 1 warnings, 173 lines checked
Patch 15/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/35 Checking commit 711b45dbcacd (Hexagon (target/hexagon/arch.[ch]) utility
functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
total: 0 errors, 1 warnings, 334 lines checked
Patch 16/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/35 Checking commit 47b9ef07279b (Hexagon (target/hexagon/conv_emu.[ch])
utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
total: 0 errors, 1 warnings, 208 lines checked
Patch 17/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/35 Checking commit e754350e3f9c (Hexagon (target/hexagon/fma_emu.[ch])
utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
ERROR: "foo * bar" should be "foo *bar"
#414: FILE: target/hexagon/fma_emu.c:392:
+static inline SUFFIX accum_round_##SUFFIX(Accum a, float_status * fp_status) \
WARNING: Block comments use a leading /* on a separate line
#418: FILE: target/hexagon/fma_emu.c:396:
+ /* result zero */ \
WARNING: Block comments use a leading /* on a separate line
#426: FILE: target/hexagon/fma_emu.c:404:
+ /* Normalize right */ \
WARNING: Block comments use a leading /* on a separate line
#427: FILE: target/hexagon/fma_emu.c:405:
+ /* We want MANTBITS bits of mantissa plus the leading one. */ \
WARNING: Block comments use a leading /* on a separate line
#428: FILE: target/hexagon/fma_emu.c:406:
+ /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \
WARNING: Block comments use a leading /* on a separate line
#429: FILE: target/hexagon/fma_emu.c:407:
+ /* So we need to normalize right while the high word is non-zero and \
WARNING: Block comments should align the * on each line
#430: FILE: target/hexagon/fma_emu.c:408:
+ /* So we need to normalize right while the high word is non-zero and \
+ * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \
WARNING: Block comments use a leading /* on a separate line
#435: FILE: target/hexagon/fma_emu.c:413:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#445: FILE: target/hexagon/fma_emu.c:423:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#452: FILE: target/hexagon/fma_emu.c:430:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#461: FILE: target/hexagon/fma_emu.c:439:
+ /* OK, we're relatively canonical... now we need to round */ \
WARNING: Block comments use a leading /* on a separate line
#466: FILE: target/hexagon/fma_emu.c:444:
+ /* Chop and we're done */ \
WARNING: Block comments use a leading /* on a separate line
#480: FILE: target/hexagon/fma_emu.c:458:
+ /* round up if guard is 1, down if guard is zero */ \
WARNING: Block comments use a leading /* on a separate line
#483: FILE: target/hexagon/fma_emu.c:461:
+ /* exactly .5, round up if odd */ \
WARNING: Block comments use a leading /* on a separate line
#489: FILE: target/hexagon/fma_emu.c:467:
+ /* \
WARNING: Block comments use a leading /* on a separate line
#498: FILE: target/hexagon/fma_emu.c:476:
+ /* Overflow? */ \
WARNING: Block comments use a leading /* on a separate line
#500: FILE: target/hexagon/fma_emu.c:478:
+ /* Yep, inf result */ \
WARNING: Block comments use a leading /* on a separate line
#522: FILE: target/hexagon/fma_emu.c:500:
+ /* Underflow? */ \
WARNING: Block comments use a leading /* on a separate line
#524: FILE: target/hexagon/fma_emu.c:502:
+ /* Leading one means: No, we're normal. So, we should be done... */ \
total: 1 errors, 19 warnings, 738 lines checked
Patch 18/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/35 Checking commit cb967e801ff4 (Hexagon (target/hexagon/imported) arch
import)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46:
new file mode 100644
total: 0 errors, 1 warnings, 9236 lines checked
Patch 19/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/35 Checking commit c47298e2a98a (Hexagon (target/hexagon) generator phase 1
- C preprocessor for semantics)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24:
new file mode 100644
ERROR: suspicious ; after while (0)
#89: FILE: target/hexagon/gen_semantics.c:61:
+ } while (0);
total: 1 errors, 1 warnings, 88 lines checked
Patch 20/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/35 Checking commit 57a4f7ce5386 (Hexagon (target/hexagon) generator phase 2
- generate header files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47:
new file mode 100755
WARNING: line over 80 characters
#998: FILE: target/hexagon/gen_tcg_funcs.py:53:
+ f.write(" tcg_gen_mov_tl(hex_new_value[%s + 1], hex_gpr[%s +
1]);\n" % \
WARNING: line over 80 characters
#1079: FILE: target/hexagon/gen_tcg_funcs.py:134:
+ f.write(" TCGv %s%sN = hex_new_pred_value[insn->regno[%d]];\n"
% \
WARNING: line over 80 characters
#1161: FILE: target/hexagon/gen_tcg_funcs.py:216:
+ f.write(" hex_gpr[%s%sN + 1]);\n"
% \
WARNING: line over 80 characters
#1238: FILE: target/hexagon/gen_tcg_funcs.py:293:
+ f.write(" gen_log_predicated_reg_write_pair(%s%sN, %s%sV,
insn->slot);\n" % \
total: 0 errors, 5 warnings, 1565 lines checked
Patch 21/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/35 Checking commit dba3c7730839 (Hexagon (target/hexagon) generator phase 3
- C preprocessor for decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#71: FILE: target/hexagon/gen_dectree_import.c:45:
+#define Q6INSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+ [TAG] = BEH,
ERROR: Macros with complex values should be enclosed in parenthesis
#73: FILE: target/hexagon/gen_dectree_import.c:47:
+#define EXTINSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+ [TAG] = BEH,
ERROR: Macros with complex values should be enclosed in parenthesis
#81: FILE: target/hexagon/gen_dectree_import.c:55:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,
ERROR: Macros with complex values should be enclosed in parenthesis
#90: FILE: target/hexagon/gen_dectree_import.c:64:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,
ERROR: suspicious ; after while (0)
#187: FILE: target/hexagon/gen_dectree_import.c:161:
+ } while (0);
total: 5 errors, 1 warnings, 188 lines checked
Patch 22/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/35 Checking commit 2b3ac8594cc7 (Hexagon (target/hexagon) generater phase 4
- decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100755
total: 0 errors, 1 warnings, 351 lines checked
Patch 23/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/35 Checking commit 81ebb5491b60 (Hexagon (target/hexagon) opcode data
structures)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#64: FILE: target/hexagon/opcodes.c:41:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO,
ERROR: Macros with complex values should be enclosed in parenthesis
#74: FILE: target/hexagon/opcodes.c:51:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,
ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: target/hexagon/opcodes.c:61:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,
ERROR: Macros with complex values should be enclosed in parenthesis
#92: FILE: target/hexagon/opcodes.c:69:
+#define DEF_SHORTCODE(TAG, SHORTCODE) [TAG] = #SHORTCODE,
ERROR: Macros with complex values should be enclosed in parenthesis
#131: FILE: target/hexagon/opcodes.c:108:
+#define ATTRIBS(...) , ## __VA_ARGS__, 0
total: 5 errors, 1 warnings, 200 lines checked
Patch 24/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/35 Checking commit 005ab9b210db (Hexagon (target/hexagon) macros)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 592 lines checked
Patch 25/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/35 Checking commit f31557d29d2e (Hexagon (target/hexagon) instruction
classes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
ERROR: Macros with complex values should be enclosed in parenthesis
#48: FILE: target/hexagon/iclass.c:23:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) \
+ [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,
ERROR: Macros with complex values should be enclosed in parenthesis
#50: FILE: target/hexagon/iclass.c:25:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) \
+ [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,
ERROR: Macros with complex values should be enclosed in parenthesis
#131: FILE: target/hexagon/iclass.h:27:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE),
ERROR: Macros with complex values should be enclosed in parenthesis
#132: FILE: target/hexagon/iclass.h:28:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) ICLASS_FROM_TYPE(TYPE),
total: 4 errors, 1 warnings, 174 lines checked
Patch 26/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/35 Checking commit 5536087f21c2 (Hexagon (target/hexagon) TCG generation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 356 lines checked
Patch 27/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/35 Checking commit f1052bcebc3d (Hexagon (target/hexagon) TCG for
instructions with multiple definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19:
new file mode 100644
total: 0 errors, 1 warnings, 198 lines checked
Patch 28/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/35 Checking commit e1b7dd644074 (Hexagon (target/hexagon) TCG for floating
point instructions)
30/35 Checking commit 6a6f45037217 (Hexagon (target/hexagon) translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
total: 0 errors, 1 warnings, 841 lines checked
Patch 30/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/35 Checking commit c3bb4a8375b1 (Hexagon (linux-user/hexagon) Linux user
emulation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#63:
new file mode 100644
ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x'
prefix instead
#143: FILE: linux-user/hexagon/cpu_loop.c:76:
+ EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting\n",
total: 1 errors, 1 warnings, 1040 lines checked
Patch 31/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/35 Checking commit 913d305b658e (Hexagon (tests/tcg/hexagon) TCG tests -
multiarch)
ERROR: line over 90 characters
#42: FILE: tests/tcg/configure.sh:99:
+
alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47:
new file mode 100644
total: 1 errors, 1 warnings, 1562 lines checked
Patch 32/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/35 Checking commit 5b0fe95a4952 (Hexagon (tests/tcg/hexagon) TCG tests -
atomics/load/store/misc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45:
new file mode 100644
total: 0 errors, 1 warnings, 1150 lines checked
Patch 33/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/35 Checking commit 5796dfef3a69 (Hexagon (tests/tcg/hexagon) TCG tests -
floating point)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 376 lines checked
Patch 34/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/35 Checking commit 98e192bf971b (Hexagon build infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
WARNING: line over 80 characters
#67: FILE: scripts/qemu-binfmt-conf.sh:139:
+hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00'
ERROR: line over 90 characters
#68: FILE: scripts/qemu-binfmt-conf.sh:140:
+hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
total: 1 errors, 2 warnings, 226 lines checked
Patch 35/35 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20210217234023.1742406-1-richard.henderson@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210217234023.1742406-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PULL 28/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions, (continued)
- [PULL 28/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions, Richard Henderson, 2021/02/17
- [PULL 32/35] Hexagon (tests/tcg/hexagon) TCG tests - multiarch, Richard Henderson, 2021/02/17
- [PULL 34/35] Hexagon (tests/tcg/hexagon) TCG tests - floating point, Richard Henderson, 2021/02/17
- [PULL 24/35] Hexagon (target/hexagon) opcode data structures, Richard Henderson, 2021/02/17
- [PULL 26/35] Hexagon (target/hexagon) instruction classes, Richard Henderson, 2021/02/17
- [PULL 29/35] Hexagon (target/hexagon) TCG for floating point instructions, Richard Henderson, 2021/02/17
- [PULL 35/35] Hexagon build infrastructure, Richard Henderson, 2021/02/17
- [PULL 30/35] Hexagon (target/hexagon) translation, Richard Henderson, 2021/02/17
- [PULL 31/35] Hexagon (linux-user/hexagon) Linux user emulation, Richard Henderson, 2021/02/17
- [PULL 33/35] Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc, Richard Henderson, 2021/02/17
- Re: [PULL 00/35] hexagon initial commit,
no-reply <=
- Re: [PULL 00/35] hexagon initial commit, Peter Maydell, 2021/02/18