[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/8] hw/sh4: Add missing Kconfig dependency on SH7750 for
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 2/8] hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board |
Date: |
Sun, 21 Feb 2021 20:43:42 +0000 |
On Sun, 21 Feb 2021 at 20:03, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> r2d_init() calls sh7750_init() so depends on SH7750.Harmless
> at the moment because nothing actually uses CONFIG_SH7750
> (hw/sh4/meson.build always compiles sh7750.c and sh7750_regnames.c
> unconditionally).
>
> Fixes: 7ab58d4c841 ("sh4-softmmu.mak: express dependencies with Kconfig")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/sh4/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/sh4/Kconfig b/hw/sh4/Kconfig
> index 4cbce3a0ed5..0452b4624ae 100644
> --- a/hw/sh4/Kconfig
> +++ b/hw/sh4/Kconfig
> @@ -10,6 +10,7 @@ config R2D
> select PCI
> select SM501
> select SH4
> + select SH7750
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v2 0/8] hw/sh4: Kconfig cleanups, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v2 1/8] hw/sh4: Add missing license, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v2 2/8] hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board, Philippe Mathieu-Daudé, 2021/02/21
- Re: [PATCH v2 2/8] hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board,
Peter Maydell <=
- [PATCH v2 3/8] hw/intc: Introduce SH_INTC Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v2 4/8] hw/char: Introduce SH_SCI Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v2 5/8] hw/timer: Introduce SH_TIMER Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v2 6/8] hw/block: Introduce TC58128 eeprom Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21
- [PATCH v2 7/8] hw/pci-host: Introduce SH_PCI Kconfig entry, Philippe Mathieu-Daudé, 2021/02/21