Re: [PATCH v2 4/8] hw/char: Introduce SH_SCI Kconfig entry

[Philippe Mathieu-Daudé]

On 2/21/21 9:45 PM, Peter Maydell wrote:
> On Sun, 21 Feb 2021 at 20:03, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> We want to be able to use the 'SH4' config for architecture
>> specific features. Add more fine-grained selection by adding
>> a CONFIG_SH_SCI selector for the SH4 serial controller.
>>
>> Add the missing MAINTAINERS entries.
>>
>> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS         | 2 ++
>>  hw/char/Kconfig     | 3 +++
>>  hw/char/meson.build | 2 +-
>>  hw/sh4/Kconfig      | 1 +
>>  4 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index da10756abf7..34587d90637 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1387,6 +1387,7 @@ R2D
>>  M: Yoshinori Sato <ysato@users.sourceforge.jp>
>>  R: Magnus Damm <magnus.damm@gmail.com>
>>  S: Odd Fixes
>> +F: hw/char/sh_serial.c
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>>  F: include/hw/sh4/sh_intc.h
>> @@ -1395,6 +1396,7 @@ Shix
>>  M: Yoshinori Sato <ysato@users.sourceforge.jp>
>>  R: Magnus Damm <magnus.damm@gmail.com>
>>  S: Odd Fixes
>> +F: hw/char/sh_serial.c
>>  F: hw/sh4/shix.c
>>  F: hw/intc/sh_intc.c
>>  F: include/hw/sh4/sh_intc.h
> 
> I didn't realise you could list a file twice in MAINTAINERS,
> but we I guess we already do for sh_intc.c.

In this case this isn't very useful because both machines
have the same set of maintainers, otherwise it is when a
same (device) section is used by machines maintained by
different persons.

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Thanks for reviewing this series!

Phil.