[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ui/console: Pass placeholder surface to displays

From: Gerd Hoffmann
Subject: Re: [PATCH v2] ui/console: Pass placeholder surface to displays
Date: Mon, 22 Feb 2021 11:51:00 +0100


>  #define QEMU_ALLOCATED_FLAG     0x01
> +#define QEMU_PLACEHOLDER_FLAG   0x02

> +static inline int is_placeholder(DisplaySurface *surface)
> +{
> +    return surface->flags & QEMU_PLACEHOLDER_FLAG;
> +}

Interesting idea.  That approach makes sense too.

> +        if (!placeholder) {
> +            placeholder = qemu_create_message_surface(640, 480, 
> placeholder_msg);
> +            placeholder->flags |= QEMU_PLACEHOLDER_FLAG;

I think we should set the placeholder flag in
qemu_create_message_surface() because every surface created with that
function is some kind if placeholder.

Also when replacing an existing surface we should make the placeholder
the same size, to avoid pointless ui window resizes.

> -    if (!new_surface) {
> +    if (is_placeholder(new_surface)) {

We should check whenever this is the primary or a secondary window here
and only destroy secondary windows.  qemu hiding all windows but
continuing to run has great potential for user confusion ...

> -    if (!new_surface) {
> +    if (is_placeholder(new_surface)) {

Same here.

take care,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]