[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/6] docs/devel: update the container based tests
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 5/6] docs/devel: update the container based tests |
Date: |
Mon, 22 Feb 2021 12:14:33 +0000 |
User-agent: |
mu4e 1.5.8; emacs 28.0.50 |
Thomas Huth <thuth@redhat.com> writes:
> On 22/02/2021 11.14, Alex Bennée wrote:
>> This section has grown a little stale so clean-up the language and
>> examples for current usage:
>>
>> - refer to containers at the top
>> - mention podman can also be used
>> - add podman prerequisites section
>> - move to using "docker-help" for online help
>> - mention the registry and it's purpose
>> - don't refer to out-of-date min-glib image
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Thomas Huth <thuth@redhat.com>
>> ---
>> docs/devel/testing.rst | 61 +++++++++++++++++++++++++++++++-----------
>> 1 file changed, 46 insertions(+), 15 deletions(-)
> [...]
>> .. code::
>>
>> - make docker-test-build@min-glib
>> + make docker-test-build@centos7
>>
>> -This will create a container instance using the ``min-glib`` image (the
>> image
>> +This will create a container instance using the ``centos7`` image (the image
>> is downloaded and initialized automatically), in which the ``test-build``
>> job
>> is executed.
>
> We're going to drop support for CentOS 7 in three months (May) ... so maybe
> it makes more sense to directly use centos8 or another long-term distro here?
>
>> +Registry
>> +--------
>> +
>> +The QEMU project has a container registry hosted by GitLab at
>> +``registry.gitlab.com/qemu-project/qemu`` which will automatically be
>> +used to pull in pre-built layers. This avoids unnecessary strain on
>> +the distro archives created by multiple developers running the same
>> +container build steps over and over again. This can be overridden
>> +locally by using the ``NOCACHE`` build option:
>
> Thanks a lot for adding the information!
>
> Thomas
Is that a r-b if I change to centos8?
--
Alex Bennée